Skip to content

Work orders: renewal email matches the signing flow; offering clears a stale send error - #83

Merged
jlwaugh merged 1 commit into
stagingfrom
feature/work-orders-integration
Oct 27, 2026
Merged

jlwaugh merged 1 commit into
stagingfrom
feature/work-orders-integration

Conversation

@saadiqbal-dev

Copy link
Copy Markdown
Collaborator

Follow-up to #82, which merged right before this fix landed. It fixes the two low-severity renewal findings from multi-review on 1f6fa4d.

Changes

  • A successful offer clears an old send error. If sending a renewal fails, it stays a draft with the reason. Without Documenso, nothing cleared that reason after the admin later offered it successfully, so the work order kept showing it under "Needs attention". offerRow now clears it on success.
  • The renewal email matches the signing flow:
    • With Documenso: "Sign the renewal: Work Order X", with the representative's signing link.
    • Without Documenso: "Work Order X renews: {builder} accepts it next". It explains that the agency countersigns once the builder has accepted.
    • Renewal couldn't be sent: "The renewal X wasn't sent: it needs you", with the reason.

Testing

  • New tests:
    • A send error is cleared by a successful offer. This test fails on the previous code.
    • The in-app renewal email wording.
    • The subject when a renewal couldn't be sent.
  • API: 712 passed. Biome and typecheck are clean.
  • No migrations.

…ffer clears an old send error

Without Documenso the renewal email says the builder accepts it first and
the agency countersigns after, instead of asking the agency to sign; an
unsent renewal gets its own subject. Offering clears a stale send error so
it no longer shows as needing attention.
@saadiqbal-dev

Copy link
Copy Markdown
Collaborator Author

@multi-review

@jlwaugh
jlwaugh merged commit c09caee into staging Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants