Skip to content

Agent flow + goals: change placement, drawn explainer, comment/todo policy - #431

Merged
elliotBraem merged 2 commits into
feat/runtime-mapfrom
docs/agent-flow-and-goals
Oct 24, 2026
Merged

elliotBraem merged 2 commits into
feat/runtime-mapfrom
docs/agent-flow-and-goals

Conversation

@elliotBraem

Copy link
Copy Markdown
Contributor

Stacked on #428. Follow-up from the 2026-10-24 retro.

What

  1. docs/agents/change-placement.md — one branch per need: bug (reproduce → classify local vs pinned platform → fix or upstream), missing capability (search first → smallest reference implementation → upstream with it attached → sync-safe interim + cleanup ticket), pattern improvement (child ADR vs upstream ADR), improving the flow itself. First rule encodes the retro's learning: sync-owned files are a contribution channel, not a fence — edit them here and file upstream in the same PR, because bos upgrade regenerates those paths (and the whole authored half of AGENTS.md) from the template.
  2. docs/agents/how-it-fits.md — the human teach layer: drawn tour of the runtime (authored → published → resolved → served; mounts/core-wins; generated types; where source lives) plus framework-internals pointers for the dig. /teach builds lessons from it; README links it.
  3. CODING_STANDARDS.md — the goals as review-time rules with concrete citations: write code once (fix once/feature once, everyone gets it; local-only fix = fork), type safety as the drift killer (infer from schemas/clients, never restate, generated beats hand-maintained), workaround protocol (upstream issue + cleanup ticket + upgrade-safe wiring), comments policy — none in implementation, KEEP: earns one, TODO(<ticket>) references tracked work, bare TODO is a violation; deletions-first for superfluous tests.
  4. Pointers in AGENTS.md + README.

Deliberately not here

No comment-lint script — review-time enforcement from the diff is the mechanism (retro decision); the discipline is covered by the KEEP/TODO contract in the standards.

Upstream counterparts (same-PR pairing)

Issue
types gen owns the composition inventory (removes the child script + its upgrade hazard) everything-dev#594
Wire @shadcn/lint (dep ships, nothing runs it) everything-dev#595
Child AGENTS.md regeneration + skills-lock trim + promote these docs + standards scaffold everything-dev#577 (commented)

Verification

Docs-only: pnpm run lint green; mermaid blocks render on GitHub; links target-checked.

@elliotBraem

Copy link
Copy Markdown
Contributor Author

Second follow-up commit pushed (0213213f1) covering the retro's remaining asks:

  1. how-it-fits.md — "Read the runtime's own state": teachings now derive from .bos/ (generated map, resolved-config vs published-parent comparison, logs as last-resort truth, platform manifest, deploy-state, sync-backup, regression caches) + the clean-at-source rule citing everything-dev#596 (log retention, TODO(#596) in-doc).
  2. docs/agents/testing.md (new doctrine): when to test / which layer / the parent-coverage boundary (published npm ships no tests — engine suites live upstream; verify-runtime-map is the cheap claim check; upstream #593 named as the future home) / regression-setup fit (boot economics, cookie cache, serial-by-design, watchdog) / how to write a good regression test. tests/README.md + AGENTS.md now point at it.
  3. Branching and stacking in change-placement.md (+ one line in the everything-dev-app skill): default one-branch-per-ticket; stack only on unmerged-own dependencies, branching from the named base — never from the working tree's HEAD (cites the fix(regression): align onboarding-stats specs with the published auth plugin #429 absorption caught pre-push); parallel independent work coordinates via conflict comments (the fix(changesets): restore the Release workflow after the auth-plugin removal #416 model).
  4. everything-dev#597 filed: promote these docs into the template (clone/degit → docs/agents/**), linking #577/#593/#594/#596.

All three docs sit in sync globs deliberately — #597 is what makes them permanent for every child.

…s goals

- docs/agents/change-placement.md: one branch per need — bug, missing
  capability, pattern improvement, improving the flow itself. First rule
  encodes the session's learning: sync-owned files are a contribution
  channel, not a fence — edit there AND file upstream in the same PR.
- docs/agents/how-it-fits.md: human-facing drawn tour of the runtime
  (authored → published → resolved → served; mounts/core-wins; generated
  types; where source lives; framework-internals pointers). /teach builds
  lessons from it.
- CODING_STANDARDS.md: write-once / type-safety-as-drift-killer / workaround
  goals added as review-time rules with concrete citations; comments policy
  — none in implementation, `KEEP:` earns one, `TODO(<ticket>)` points at
  tracked work; deletions-first for comments and tests. No script: review
  enforces it from the diff.
- AGENTS.md + README: pointers to the flow, the explainer, the standards.
…ing rules

- how-it-fits.md: "Read the runtime's own state" — the .bos surfaces table
  (generated map, resolved-config vs published comparison, logs as last-resort
  truth, platform manifest, deploy-state, sync-backup, regression caches) plus
  the clean-at-source rule with TODO(#596) citing the upstream log-retention
  issue; teach-from-state principle added.
- change-placement.md: classify via resolved-config comparison; clean-up-at-
  source rule; new "Branching and stacking" section (default one-branch-per-
  ticket; stack only on unmerged-own dependencies, branching from the named
  base; never branch from the working tree HEAD — cite the #429 absorption;
  parallel independent work coordinates via conflict comments, #416 model).
- docs/agents/testing.md (new): when to test, the three layers, the
  parent-coverage boundary (compose/hydrate/mounts assumed upstream, npm ships
  no tests; verify-runtime-map as the cheap claim check; upstream #593 the
  future home), fitting the regression setup (boot economics, cookie cache,
  serial-by-design, watchdog), and how to write a good regression test.
- tests/README.md + AGENTS.md: pointers to the doctrine; everything-dev-app
  skill: stack-on-named-base line in Work the frontier.

All doc paths land in sync globs so the promotion ticket carries them upstream.
@elliotBraem
elliotBraem force-pushed the docs/agent-flow-and-goals branch from 0213213 to ecb9a4c Compare October 24, 2026 21:05
@elliotBraem
elliotBraem merged commit a5deb8a into main Oct 24, 2026
6 checks passed
@elliotBraem
elliotBraem deleted the docs/agent-flow-and-goals branch October 24, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant