Repository navigation
feat(events): Submit report button on past events the community shows - #467
Merged
Merged
Conversation
Past events a community shows on its calendar get a Submit report button on the Events tab that opens the post-event report form in a new tab. Hidden or removed imports, drafts and cancelled events don't get it.
Multi Review ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Submit report button to past events on a community's Events tab. It opens the shared post-event report form (https://docs.google.com/forms/d/e/1FAIpQLSdGTdQ9znOJbObaeef7NHAzXc04OygTLIOu6Qv1dKRx8Fwxxw/viewform) in a new tab. Per the team discussion, one shared Google Form link is hardcoded for now; moving reports into the dashboard will be scoped separately.
Which events get it
Only events the community has published or shown and that have ended: what the "Ended" badge already uses (
eventVisibility() === "ended"). Hidden or removed Luma imports, drafts and cancelled events don't get the button. It sits next to the other actions on the event card, so everyone who can manage the Events tab sees it.Changes
activity-editor.tsx: Submit report button on ended, visible events (target=_blank,rel=noopener noreferrer)discovery.ts:events.submitReportin en/es/fr/zhowner-event-visibility.spec.ts: the ended event has the form link in a new tab; a past hidden import has no buttonuipatch)Testing
pnpm lint,pnpm typecheck,pnpm test,pnpm test:regression:unitpassowner-event-visibilitybrowser spec (dev:ssr) passes 2/2