Repository navigation
fix(ui): show City Nodes in link previews - #470
Merged
Merged
Conversation
Set the app description, replace the upstream metadata image with a City Nodes card, update the web manifest, and give the home, Explore, community and profile pages their own og/twitter tags. Closes #469
Multi Review ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
Link previews for citynode.app showed the everything.dev card (upstream description and the "Under construction" image). Everything is set in this repo, so the pinned prod image doesn't depend on upstream.
bos.app.ts: adddescription, soruntime.description(used by the rootog:description/twitter:description) no longer falls back to the parent configui/public/metadata.png: replaced with a 1200x630 City Nodes cardsite.webmanifest: City Nodes name and descriptionui/src/lib/social-meta.tswrapsgetSocialImageMeta./,/explore,/n/$slugand/$accountIdnow set their own og/twitter title, description andog:url. TanStack dedupes by name/property, so the page's tags win over the root's.Before: raw HTML from prod (
curl -sL https://citynode.app/explore)After: raw server-rendered HTML (local
bos dev --ssr,curl -s)Titles:
Each og/twitter tag shows up once per page.
og:imageis absolute and/metadata.pngreturns200 image/png(175 KB). Locally the host islocalhost:3000; on prod it'shostUrl(https://citynode.app).Tested
pnpm run typecheck,pnpm run lint,pnpm run test: all pass/,/exploreand/n/<test community>(output above). On main, localbos dev --ssrfails because the remote host wants everything-dev rc.27 and main pins rc.25. For this check only, I bumped everything-dev to rc.27 locally without committing it and reverted afterwards. The PR doesn't change versions.Image before / after: