Fix/sr ndit 1663#127
Merged
Merged
Conversation
…fter data contract validations
…spark parsers to only cast where format exactly as stipulated
georgeRobertson
approved these changes
Jul 10, 2026
| for column in spark_schema | ||
| if column.name in record_df.columns | ||
| ] | ||
| *[ |
Contributor
There was a problem hiding this comment.
add a #todo for v0.9 as this is breaking in pydantic v2
| pyarrow = "23.0.1" | ||
| pydantic = "1.10.19" | ||
| pyspark = ">=3.0.0,<=3.5.2" | ||
| pyspark = ">=3.5.0,<=3.5.2" |
|
georgeRobertson
added a commit
that referenced
this pull request
Jul 14, 2026
* Fix/sr ndit 1663 (#127) * fix: fix issue with non iso date/datetime values in duck db casting after data contract validations (#127) * fix: implement non iso timestamp formats in spark. constrain ddb and spark parsers to only cast where format exactly as stipulated (#127) * fix: linting and typing fixes * build: bump pyspark to 3.5.5 and address review comments --------- Co-authored-by: george.robertson1 <50412379+georgeRobertson@users.noreply.github.com> * docs: fix 'Bad Value' in cases where it should be 'Bad value' (#128) * build: upgrade zensical from 0.0.31 to 0.0.46 * docs: fix some of the urls that are pointing at invalid locations * ci: add ci job to ensure that docs are building correctly * bump: version 0.8.2 → 0.8.3 * docs: update changelog manually for dve v0.8.3 release --------- Co-authored-by: stevenhsd <56357022+stevenhsd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR of changes
Allow custom date formats to cascade to contract stage for casting. Ensure strict casting only - if a date doesn't meet the format exactly then it will be nulled - duckdb is too permissive and spark can error if not the case.
What kind of changes does this PR introduce?
Tick all that apply
Please check if the PR fulfills these requirements