Skip to content

feat: add a static inbound option for the private dns resolver#313

Merged
MacMur85 merged 2 commits into
mainfrom
feat/DTOSS-13182-dns-resolver-module-static-inbound-ip
Jun 19, 2026
Merged

feat: add a static inbound option for the private dns resolver#313
MacMur85 merged 2 commits into
mainfrom
feat/DTOSS-13182-dns-resolver-module-static-inbound-ip

Conversation

@MacMur85

@MacMur85 MacMur85 commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Change is adding a private_ip_address support to Private DNS Resolver inbound endpoint and extends the inbound_endpoint_config variable in the Private DNS Resolver module to support static IP address assignment for the inbound endpoint.

Changes

  • Added private_ip_address as an optional field to the inbound_endpoint_config object type
  • Updated azurerm_private_dns_resolver_inbound_endpoint to conditionally pass private_ip_address to the ip_configurations block only when private_ip_allocation_method is set to "Static"

Validations

Two validation rules have been added to the inbound_endpoint_config variable:

  1. Allowed values - private_ip_allocation_method must be either "Static" or "Dynamic". Any other value will fail at plan time.
  2. Conditional requirement - private_ip_address must be provided when private_ip_allocation_method is set to "Static". If omitted, Terraform will fail at plan time with a descriptive error message.

Usage

No breaking changes. Existing callers using "Dynamic" allocation do not need to update their configuration - private_ip_address defaults to null and is silently ignored.

Context

  • Added private_ip_address as an optional field to the inbound_endpoint_config object type
  • Updated azurerm_private_dns_resolver_inbound_endpoint to conditionally pass private_ip_address to the ip_configurations block only when private_ip_allocation_method is set to "Static"

Validations

Two validation rules have been added to the inbound_endpoint_config variable:

  1. Allowed values - private_ip_allocation_method must be either "Static" or "Dynamic". Any other value will fail at plan time.
  2. Conditional requirement - private_ip_address must be provided when private_ip_allocation_method is set to "Static". If omitted, Terraform will fail at plan time with a descriptive error message.

Usage

No breaking changes. Existing callers using "Dynamic" allocation do not need to update their configuration - private_ip_address defaults to null and is silently ignored.

# Static allocation - private_ip_address required
inbound_endpoint_config = {
  name                         = "dns-resolver-inbound-prod"
  private_ip_allocation_method = "Static"
  subnet_id                    = azurerm_subnet.dns_inbound.id
  private_ip_address           = "10.100.7.4"
}

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@MacMur85 MacMur85 force-pushed the feat/DTOSS-13182-dns-resolver-module-static-inbound-ip branch from 6ce003c to 855985b Compare June 18, 2026 10:24
@MacMur85 MacMur85 marked this pull request as draft June 18, 2026 10:25
@MacMur85 MacMur85 marked this pull request as ready for review June 19, 2026 08:45

@nc-shahidazim nc-shahidazim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MacMur85 MacMur85 added this pull request to the merge queue Jun 19, 2026
Merged via the queue into main with commit a6da87c Jun 19, 2026
13 checks passed
@MacMur85 MacMur85 deleted the feat/DTOSS-13182-dns-resolver-module-static-inbound-ip branch June 19, 2026 10:50
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants