Enable YAML tests #11
Open
gabriel-pq wants to merge 5 commits into
Open
Conversation
CAAS-3169: update linting and tests # This is the commit message #2: CAAS-3169: update linting and tests - yml # This is the commit message #3: CAAS-3169: fix linting in pipeline # This is the commit message #4: CAAS-3169: fix linting in pipeline - 2 # This is the commit message #5: CAAS-3169: mock bucket tests? # This is the commit message #6: CAAS-3169: mock bucket tests - 2 # This is the commit message #7: CAAS-3169: mock bucket tests - maybe too much? # This is the commit message #8: CAAS-3169: mock bucket tests - remove # This is the commit message #9: CAAS-3169: change a bit the tests # This is the commit message #10: CAAS-3169: checking for test environment, but GitHub Actions doesn't set NODE_ENV # This is the commit message #11: CAAS-3169: update local stack # This is the commit message #12: CAAS-3169: debug mock bucket # This is the commit message #13: CAAS-3169: more debugging CAAS-3169: more debugging CAAS-3169: add little delay CAAS-3169: starting to have mixed feelings for this test CAAS-3169: it can't access the /tmp/localstack directory CAAS-3169: oof CAAS-3169: new attempt with ports to communicate CAAS-3169: goinng back to the issue of before CAAS-3169: indent CAAS-3169: rely on localstack CAAS-3169: rely on localstack 1 CAAS-3169: rely on localstack 2 CAAS-3169: rely on localstack 3 CAAS-3169: rely on localstack 4 CAAS-3169: rely on localstack 5 CAAS-3169: rely on localstack 5 CAAS-3169: rely on localstack 6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a WIP, due to time limitations on the original ticket.
I integrated LocalStack in the YAML, so we can use our bespoke code for download-or-upload artefacts.
On ubuntu the majority of the tests are passing, we need to create some files/folders necessary for the Download tests, as atm they fail due to the files/folders not bein present.
On macos we get this error when trying to start LocalStack:
Error: Docker could not be found on the system.On windows we get this error when trying to start LocalStack:
Error: 'charmap' codec can't encode character '\U0001f433' in position 35: character maps to <undefined>Latest pipeline: https://github.com/NHSDigital/transfer-artifact/actions/runs/13057951252