Repository navigation
fix(nve-combobox): oppdatere css og ikon paa nve-combobox og nve-input i readonly - #1022
Merged
lisamarimyreneNVE merged 7 commits intoOct 7, 2026
Conversation
lisamarimyreneNVE
requested review from
NVEJoel,
amish1188,
gruble,
malingranlynve and
tomapedersen
as code owners
October 7, 2026 09:44
…_nve-input_i_readonly
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused styling and icon changes have no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Updates readonly styling for combobox and input components to match the revised designs.
Changes:
- Adjusts readonly text colors and removes the combobox border.
- Replaces the readonly combobox icon with
edit_offand updates its test.
| File | Description |
|---|---|
| src/components/nve-input/nve-input.styles.ts | Adds a readonly text-color fallback. |
| src/components/nve-combobox/nve-combobox.test.ts | Checks the readonly icon. |
| src/components/nve-combobox/nve-combobox.styles.ts | Updates readonly colors, border, and icon size. |
| src/components/nve-combobox/nve-combobox.component.ts | Uses the edit_off readonly icon. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tomapedersen
approved these changes
Oct 7, 2026
amish1188
reviewed
Oct 7, 2026
amish1188
reviewed
Oct 7, 2026
…i_readonly' of https://github.com/NVE/Designsystem into fix/oppdatere-css_og_ikon_paa_nve-combobx_og_nve-input_i_readonly
…ppdatere-css_og_ikon_paa_nve-combobx_og_nve-input_i_readonly
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-1022.westeurope.5.azurestaticapps.net |
amish1188
approved these changes
Oct 7, 2026
Contributor
|
🎉 This PR is included in version 5.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1001