Skip to content

Add nvskills support - #30

Open
ohadmo wants to merge 4 commits into
mainfrom
omosafi/skills
Open

Add nvskills support#30
ohadmo wants to merge 4 commits into
mainfrom
omosafi/skills

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo ohadmo self-assigned this Sep 10, 2026
@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai

@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable regression caused by the packaging and path restructuring was identified.

Summary

  • Moves canonical workflow scripts, defaults, and released-model guidance under skills/_shared/.
  • Bundles each skill’s required scripts and configuration while adding drift and packaging validation.
  • Updates container execution to mount the installed skill at /skill separately from the runtime KERMT checkout.
  • Repoints Claude discovery, documentation, tests, and workflow commands to the new layout.
  • Adds GitHub Actions checks for bundled-file consistency and independent installation behavior.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  U[User or agent] --> S[Installed KERMT skill]
  S --> H[Bundled container helper]
  H --> C[KERMT container]
  R[Runtime KERMT checkout] -->|/workspace| C
  S -->|/skill read-only| C
  D[User data and checkpoints] -->|read-only mounts| C
  C --> V[Validation and preparation]
  V --> W[Training, inference, or embedding]
  W --> O[Run artifacts and manifests]
  X[skills/_shared canonical assets] --> Y[sync_shared.py]
  Y --> S
  CI[Packaging CI] --> Y
Loading

Reviews (1) · Last reviewed commit: "fix links"

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

Too many files changed for review (140 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@ohadmo

ohadmo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants