Migrate skill aggregate to skills/ and unblock NVSkills evaluations - #27
Merged
Merged
Conversation
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
Greptile SummaryThe PR resolves evaluation and synchronization failures by renaming the nvMolKit skill consistently, retaining generated evaluation/signing artifacts during payload rebuilds, and refreshing generated plugin content.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope. No blocking failure remains. Important Files Changed
Reviews (5): Last reviewed commit: "add symlink" | Re-trigger Greptile |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
The signing service commits skill.oms.sig, BENCHMARK.md, and skill-card.md into the plugin payload only (never authored in source). plugin_sync --check flagged these as "extra in payload" drift, and --write would delete them on the rmtree+copytree rebuild — silently dropping a committed signature. Treat them as generated, payload-only artifacts: skip skill-root skill.oms.sig / BENCHMARK.md / skill-card.md in the freshness comparison, and preserve them across a --write rebuild. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
|
Too many files changed for review (308 files, 100 file limit). Bypass the limit by tagging |
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
ohadmo
changed the title
jwilber
approved these changes
Aug 14, 2026
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Collaborator
Author
|
/nvskills-ci |
1 similar comment
Collaborator
Author
|
/nvskills-ci |
ohadmo
added a commit
that referenced
this pull request
Aug 25, 2026
) * Fix nvmolkit Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * Attach NVSkills validation signatures Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> * TO DROP Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * Reconcile plugin_sync with NVSkills signing artifacts The signing service commits skill.oms.sig, BENCHMARK.md, and skill-card.md into the plugin payload only (never authored in source). plugin_sync --check flagged these as "extra in payload" drift, and --write would delete them on the rmtree+copytree rebuild — silently dropping a committed signature. Treat them as generated, payload-only artifacts: skip skill-root skill.oms.sig / BENCHMARK.md / skill-card.md in the freshness comparison, and preserve them across a --write rebuild. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * add symlink Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * skills folder renaming Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * rename plugin/ folder to skills/ Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * reword binder-design eval prompts to avoid model safety guardrails Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * resolve merge conflicts Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> * Suppress evo2-nim Tier 1 SQP-2 high via audited SkillSpector baseline Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> --------- Signed-off-by: Ohad Mosafi <omosafi@nvidia.com> Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the generated BioNeMo Agent Toolkit aggregate from
plugins/bionemo-agent-toolkit/toskills/bionemo-agent-toolkit/so it isdiscovered through the current NVSkills validation path.
The legacy
plugins/path remains as a temporary symlink toskills/forcompatibility with existing consumers.
Changes
bionemo-agent-toolkitaggregate underskills/.plugins -> skillsas a temporary compatibility symlink.skills/bionemo-agent-toolkit/path.workflows for the new layout.
plugin_sync.pyto:BENCHMARK.md,skill-card.md, andskill.oms.sigartifacts during regeneration;nvMolKittonvmolkit-usage, matching the skill name.nvmolkit-usage.