Skip to content

Add nvskills workflow file - #283

Merged
scal444 merged 6 commits into
mainfrom
omosafi/nvskills
Sep 4, 2026
Merged

Add nvskills workflow file#283
scal444 merged 6 commits into
mainfrom
omosafi/nvskills

Conversation

@ohadmo

@ohadmo ohadmo commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ohadmo ohadmo self-assigned this Aug 26, 2026
@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the nvMolKit usage skill card with published evaluation metadata and adds its signed attestation bundle.

  • Records benchmark results for Claude Code and Codex.
  • Updates skill ownership, references, version, risks, and output metadata.
  • Adds the NVSkills Sigstore signature bundle.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported workflow-discovery issue is fixed because the workflow now resides under .github/workflows/.

Important Files Changed

Filename Overview
skills/nvmolkit-usage/skill-card.md Replaces pending skill metadata with updated release information and completed evaluation results.
skills/nvmolkit-usage/skill.oms.sig Adds the signed attestation bundle covering the skill resources.

Reviews (9): Last reviewed commit: "Delete skills/nvmolkit-usage/BENCHMARK.m..." | Re-trigger Greptile

Comment thread .github/workflows/request-nvskills-ci.yml
@ohadmo

ohadmo commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@evasnow1992

Copy link
Copy Markdown
Collaborator

Hi Ohad, thank you for adding the nvSkill workflow. Kevin is currently OOO and will complete the review when he's back. In the meantime, I also took a look at the changes and have a couple of general comments:

  1. I think the issue Greptile raised is valid: the YAML file needs to be under .github/workflows/ for the workflow to be triggered.
  2. The file is also missing the SPDX header required for our repo:
# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@scal444

scal444 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Which parts of this should actually be merged? Is it just the skill card?

@ohadmo

ohadmo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@scal444
scal444 merged commit 2defb47 into main Sep 4, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants