Unify Butina outputs for device and RDKit compatibility mode. - #285
Merged
scal444 merged 6 commits intoSep 10, 2026
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| nvmolkit/clustering.py | Introduces unified output modes and structured device results, with stream-safe cluster-size calculation and RDKit-compatible host conversion. |
| nvmolkit/tests/test_clustering.py | Updates existing callers and adds coverage for output modes, cluster sizes, exact RDKit compatibility, and member ordering. |
| skills/nvmolkit-usage/SKILL.md | Updates the Butina workflow example and explains how to consume device and RDKit output representations. |
| benchmarks/butina_clustering_bench.py | Selects device output explicitly so the benchmark continues measuring the intended GPU-oriented path. |
| docs/api/nvmolkit.rst | Adds the new output enum and device-result class to generated API documentation. |
Reviews (2): Last reviewed commit: "Address Butina review feedback" | Re-trigger Greptile
Collaborator
Author
|
/nvskills-ci |
2 similar comments
Contributor
|
/nvskills-ci |
Contributor
|
/nvskills-ci |
evasnow1992
reviewed
Sep 8, 2026
evasnow1992
reviewed
Sep 8, 2026
evasnow1992
reviewed
Sep 8, 2026
evasnow1992
approved these changes
Sep 9, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for consolidating butina outputs and addressing the comments. Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #269 , though with another API modification. There's no good way to unify fused/nonfused Butina + our previous history of return types without a clean approach.