test(rust): move large unit tests out of implementation files - #328
Draft
nachiketb-nvidia wants to merge 1 commit into
Draft
test(rust): move large unit tests out of implementation files#328nachiketb-nvidia wants to merge 1 commit into
nachiketb-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the largest inline Rust unit-test modules into sibling
*_tests.rsfiles while keeping each module registered asmod teststhrough#[path = "..."].Extracted files:
crates/libsy/src/algorithms/util/affinity.rs->affinity_tests.rscrates/switchyard-translation/src/helpers.rs->helpers_tests.rscrates/libsy/src/algorithms/stage.rs->stage_tests.rscrates/libsy/src/algorithms/rand.rs->rand_tests.rscrates/libsy/src/core/classifier.rs->classifier_tests.rsWhy
These were the obvious inline-test-heavy Rust files where test LoC was much larger than implementation LoC. Keeping the tests in sibling files makes the implementation files easier to read without changing test visibility or behavior.
How
Each implementation file now ends with:
Because the external file is still compiled as the same child
testsmodule, the moved tests retain the samesuper::*access to private implementation details. No test macros or new abstraction layer were added.Validation
cargo fmt --all --checkcargo test -p switchyard-libsycargo test -p switchyard-translationcargo fmt,cargo clippy,commitlint