refactor(cli)!: remove Hermes CLI support - #731
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout. (44)
🧰 Additional context used📓 Path-based instructions (12)**/*.{md,rst,html,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,html}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.{md,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Files:
**/*.{md,mdx,py,go,js,ts}📄 CodeRabbit inference engine (.agents/skills/maintain-observability/SKILL.md)
Files:
**/*.{rs,py,js,jsx,ts,tsx,go,c,h,cc,cpp,md,toml,yml,yaml,sh}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,go,js,jsx,ts,tsx,c,h,html,md,mdx,toml}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{md,mdx,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
Files:
**/SKILL.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
⚙️ CodeRabbit configuration file
Files:
**/*.{yaml,yml,toml,json}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
🪛 SkillSpector (2.5.1)skills/nemo-relay-get-started/SKILL.md[warning] 40: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation. Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state. (Excessive Agency (EA2)) [warning] 40: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation. Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state. (Excessive Agency (EA2)) [warning] 40: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation. Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state. (Excessive Agency (EA2)) [warning] 40: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation. Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state. (Excessive Agency (EA2)) 🔇 Additional comments (3)
WalkthroughHermes Agent support was removed from the Relay CLI, runtime event handling, hooks, tests, examples, and documentation. Claude Code and Codex remain supported CLI agents. Documentation now describes Hermes Agent’s native NeMo Relay integration. ChangesHermes Agent removal
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
willkill07
changed the title
willkill07
changed the title
willkill07
added
breaking
willkill07
changed the title
willkill07
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 13
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
crates/cli/tests/coverage/shared/config_tests.rs (2)
588-589: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd a regression test for stale
[agents.hermes]configuration.The Hermes configuration fixture and resolved-command assertion are gone. Add a negative TOML test that asserts the intended parser error for a stale
[agents.hermes]table. TheCodingAgent::infer("hermes")assertion covers executable inference only. It does not cover TOML configuration parsing or silent configuration removal.As per path instructions, tests must cover changed API behavior and error paths. The PR objective states that removed
[agents.hermes]configuration has no compatibility shim.Also applies to: 624-625
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/cli/tests/coverage/shared/config_tests.rs` around lines 588 - 589, Add a regression test in the configuration parsing tests covering a TOML fixture with a stale [agents.hermes] table, and assert the parser returns the intended error rather than silently accepting or removing the configuration. Keep the existing CodingAgent::infer("hermes") assertion for executable inference, but add this separate negative parsing case to verify removed Hermes configuration has no compatibility shim.Source: Path instructions
2174-2175: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winRetain generic MCP environment-policy coverage.
unresolved_self_placeholder_for_platformremains on the CLI path, andpreviously_forwardable_name_for_platformremains in MCP manifest validation. Keep or rehome tests for Unix/Windows matching, case sensitivity, allowed historical names, and blocked names.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/cli/tests/coverage/shared/config_tests.rs` around lines 2174 - 2175, Retain or rehome generic MCP environment-policy coverage alongside unresolved_self_placeholder_for_platform and previously_forwardable_name_for_platform. Ensure tests cover Unix/Windows matching, case sensitivity, allowed historical names, and blocked names.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/cli/src/configuration/mod.rs`:
- Around line 77-83: Update FileAgentsConfig with serde unknown-field rejection
so unsupported agents.hermes sections fail parsing instead of being discarded.
Add coverage in validate_shared_config_shape using an [agents.hermes]
configuration and assert that parse_file_config rejects it.
In `@crates/cli/src/mcp/mod.rs`:
- Line 110: Update the documentation comment above the same-process launch code
to use the complete supported-agent names and correct verb agreement, replacing
the current “Code launch” wording while preserving the comment’s meaning.
In `@docs/about-nemo-relay/release-notes/index.mdx`:
- Around line 66-73: Update the breaking-changes bullet to state that
Hermes-specific support was removed from the listed paths, rather than implying
the generic install, uninstall, doctor, configuration, and MCP-selection
commands were removed. Preserve the existing Hermes shortcut, agent, and
endpoint details while clearly indicating that those commands still support
Codex and Claude Code.
In `@docs/getting-started/about.mdx`:
- Around line 61-64: Add a discoverable Hermes Agent entry to the
getting-started integration map in docs/getting-started/about.mdx:61-64, using
the canonical native-integration guidance. Add the corresponding native Hermes
Agent row to the integration map in
docs/getting-started/quick-start/index.mdx:59-62, preserving the existing Claude
Code and Codex routes.
In `@docs/integrate-into-frameworks/about.mdx`:
- Around line 51-55: Rewrite the remaining agent lists with explicit
conjunctions: in docs/integrate-into-frameworks/about.mdx lines 51-55, state
that the section covers Claude Code and Codex support; in
docs/getting-started/quick-start/index.mdx lines 73-74, refer to a local Codex
or Claude Code session. Keep the prose concise and parallel.
In `@docs/nemo-relay-cli/basic-usage.mdx`:
- Around line 80-82: Correct the malformed conjunctions in both documentation
sites: in docs/nemo-relay-cli/basic-usage.mdx lines 80-82, change the Claude
Code/Codex list to use “and”; in docs/nemo-relay-cli/codex.mdx lines 159-160,
change the concurrent-process phrase to “Concurrent Codex and Claude Code
processes.”
In `@docs/nemo-relay-cli/plugin-installation.mdx`:
- Around line 290-291: Update the MCP bootstrap documentation near the
host-neutral configuration description to state that Hermes-specific selections
or entry points were removed, rather than claiming the --agent option no longer
parses globally. Preserve the documented supported run --agent codex and run
--agent claude flows.
In `@integrations/coding-agents/codex/README.md`:
- Line 77: Update the sentence in the README by replacing the comma after
“Concurrent Codex” with “and,” producing clear parallel construction:
“Concurrent Codex and Claude Code processes can share the gateway.”
In `@skills/nemo-relay-get-started/references/cli-try-now.md`:
- Around line 97-99: Update the configuration walkthrough around the nemo-relay
config command to remove the obsolete “Choose project scope” step and any
project-file default. Make the instructions use the supported XDG user-scoped
setup while preserving the observability, ATOF, and ATIF configuration steps.
In `@skills/nemo-relay-get-started/SKILL.md`:
- Around line 21-22: Update the built-in integration path in the skill to
explicitly include Hermes Agent alongside LangChain, LangGraph, Deep Agents, and
OpenClaw. State that Relay is built into Hermes Agent, requires no separate
Relay installation or observability-plugin setup, and hand off without providing
an install command.
In `@skills/nemo-relay-install/evals/evals.json`:
- Line 92: Update the evaluation expectation around the CLI/package/integration
choices to explicitly assert that Hermes Agent uses the native built-in path
without installation, and revise the ground_truth entry to name this no-install
Hermes behavior. Preserve the existing alternatives for CLI, language packages,
and maintained integrations.
In `@skills/nemo-relay-install/references/cli-install.md`:
- Around line 25-26: Update the PATH prerequisite in the CLI installation
documentation to require that the selected command for any supported `nemo-relay
run -- <command>` invocation is available on PATH, rather than limiting the
requirement to codex or claude; retain those commands only as examples.
In `@skills/nemo-relay-install/references/maintained-integrations.md`:
- Around line 24-26: Update the installation preamble in
maintained-integrations.md to apply only to integrations that require a separate
package, or explicitly exclude built-in Hermes Agent/NeMo Relay. Ensure Hermes
users are not told to install Relay while preserving the existing
package-install guidance for package-backed integrations.
---
Outside diff comments:
In `@crates/cli/tests/coverage/shared/config_tests.rs`:
- Around line 588-589: Add a regression test in the configuration parsing tests
covering a TOML fixture with a stale [agents.hermes] table, and assert the
parser returns the intended error rather than silently accepting or removing the
configuration. Keep the existing CodingAgent::infer("hermes") assertion for
executable inference, but add this separate negative parsing case to verify
removed Hermes configuration has no compatibility shim.
- Around line 2174-2175: Retain or rehome generic MCP environment-policy
coverage alongside unresolved_self_placeholder_for_platform and
previously_forwardable_name_for_platform. Ensure tests cover Unix/Windows
matching, case sensitivity, allowed historical names, and blocked names.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 7ecefd19-5bc4-4417-8633-568f6626f398
📒 Files selected for processing (91)
README.mdcrates/cli/README.mdcrates/cli/src/agents/claude/mod.rscrates/cli/src/agents/codex/host.rscrates/cli/src/agents/codex/mod.rscrates/cli/src/agents/hermes/adapter.rscrates/cli/src/agents/hermes/alignment.rscrates/cli/src/agents/hermes/config.rscrates/cli/src/agents/hermes/doctor.rscrates/cli/src/agents/hermes/files.rscrates/cli/src/agents/hermes/install.rscrates/cli/src/agents/hermes/integration.rscrates/cli/src/agents/hermes/launch.rscrates/cli/src/agents/hermes/mod.rscrates/cli/src/agents/hermes/trust.rscrates/cli/src/agents/mod.rscrates/cli/src/agents/shared/adapters.rscrates/cli/src/agents/shared/alignment.rscrates/cli/src/commands/configure/mod.rscrates/cli/src/commands/configure/model.rscrates/cli/src/commands/configure/wizard/prompt.rscrates/cli/src/commands/diagnostics.rscrates/cli/src/commands/install.rscrates/cli/src/commands/mod.rscrates/cli/src/commands/root.rscrates/cli/src/configuration/mod.rscrates/cli/src/configuration/types.rscrates/cli/src/events/mod.rscrates/cli/src/filesystem/mod.rscrates/cli/src/filesystem/temp.rscrates/cli/src/hooks/encoding.rscrates/cli/src/hooks/mod.rscrates/cli/src/installation/generation.rscrates/cli/src/mcp/mod.rscrates/cli/src/mcp_environment.rscrates/cli/src/process/launcher.rscrates/cli/src/server/mod.rscrates/cli/src/sessions/correlation.rscrates/cli/src/sessions/mod.rscrates/cli/src/sessions/routing.rscrates/cli/tests/architecture_tests.rscrates/cli/tests/cli_tests.rscrates/cli/tests/coverage/agents/adapters_tests.rscrates/cli/tests/coverage/agents/alignment_tests.rscrates/cli/tests/coverage/agents/coding_agent_tests.rscrates/cli/tests/coverage/agents/hermes_tests.rscrates/cli/tests/coverage/agents/launcher_tests.rscrates/cli/tests/coverage/agents/plugin_host_tests.rscrates/cli/tests/coverage/agents/plugin_install_tests.rscrates/cli/tests/coverage/commands/main_tests.rscrates/cli/tests/coverage/shared/config_tests.rscrates/cli/tests/coverage/shared/doctor_tests.rscrates/cli/tests/coverage/shared/events_tests.rscrates/cli/tests/coverage/shared/gateway_tests.rscrates/cli/tests/coverage/shared/installer_tests.rscrates/cli/tests/coverage/shared/server_tests.rscrates/cli/tests/coverage/shared/session_tests.rscrates/cli/tests/coverage/shared/setup_tests.rsdocs/about-nemo-relay/overview.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/getting-started/about.mdxdocs/getting-started/installation.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/claude-code.mdxdocs/nemo-relay-cli/codex.mdxdocs/nemo-relay-cli/hermes.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/reference/migration-guides.mdxdocs/reference/support-matrix.mdxexamples/switchyard/README.mdexamples/switchyard/hermes-ollama-plugins.tomlexamples/switchyard/hermes-ollama-profiles.yamlexamples/switchyard/run-hermes-ollama-smoke.shexamples/switchyard/run-real-e2e.shintegrations/coding-agents/README.mdintegrations/coding-agents/claude-code/README.mdintegrations/coding-agents/codex/README.mdjustfilescripts/README.mdscripts/test-hermes-mcp-e2e.shskills/nemo-relay-get-started/SKILL.mdskills/nemo-relay-get-started/evals/evals.jsonskills/nemo-relay-get-started/references/cli-try-now.mdskills/nemo-relay-install/SKILL.mdskills/nemo-relay-install/evals/evals.jsonskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-install/references/maintained-integrations.mdskills/nemo-relay-install/skill-card.md
💤 Files with no reviewable changes (31)
- crates/cli/src/agents/claude/mod.rs
- crates/cli/src/agents/codex/mod.rs
- scripts/README.md
- crates/cli/tests/coverage/commands/main_tests.rs
- crates/cli/src/commands/root.rs
- crates/cli/src/agents/hermes/trust.rs
- examples/switchyard/hermes-ollama-plugins.toml
- crates/cli/src/sessions/correlation.rs
- crates/cli/src/agents/hermes/integration.rs
- docs/nemo-relay-cli/hermes.mdx
- examples/switchyard/hermes-ollama-profiles.yaml
- examples/switchyard/run-hermes-ollama-smoke.sh
- crates/cli/tests/coverage/shared/events_tests.rs
- crates/cli/src/filesystem/temp.rs
- crates/cli/src/agents/hermes/mod.rs
- crates/cli/tests/coverage/agents/hermes_tests.rs
- crates/cli/src/agents/hermes/launch.rs
- crates/cli/src/agents/hermes/config.rs
- crates/cli/src/filesystem/mod.rs
- crates/cli/src/agents/hermes/alignment.rs
- crates/cli/src/commands/configure/model.rs
- crates/cli/src/agents/hermes/doctor.rs
- examples/switchyard/README.md
- justfile
- crates/cli/src/agents/hermes/install.rs
- scripts/test-hermes-mcp-e2e.sh
- crates/cli/src/commands/mod.rs
- crates/cli/src/agents/hermes/adapter.rs
- crates/cli/src/agents/hermes/files.rs
- crates/cli/src/configuration/types.rs
- crates/cli/tests/coverage/agents/plugin_install_tests.rs
| /// Host adapters add only schema-specific activation and environment-forwarding fields. Keeping | ||
| /// the command, arguments, fixed gateway bind, and generation fence here ensures Codex, Claude | ||
| /// Code, and Hermes launch the same process. | ||
| /// Code launch the same process. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the agent names in the documentation comment.
The comment says Code launch the same process. Use the complete supported-agent names and correct verb agreement.
Proposed fix
-/// Code launch the same process.
+/// Codex and Claude Code launch the same process.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| /// Code launch the same process. | |
| /// Codex and Claude Code launch the same process. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@crates/cli/src/mcp/mod.rs` at line 110, Update the documentation comment
above the same-process launch code to use the complete supported-agent names and
correct verb agreement, replacing the current “Code launch” wording while
preserving the comment’s meaning.
| ### Breaking Changes in 0.8 | ||
|
|
||
| - Removed Hermes Agent support from the NeMo Relay CLI, including the `hermes` | ||
| shortcut, `run --agent hermes`, install, uninstall, doctor, configuration, | ||
| MCP selection, and `/hooks/hermes` endpoint. NeMo Relay is built into Hermes | ||
| Agent, and Hermes Agent understands NeMo Relay plugin configurations. No | ||
| separate observability plugin or Relay CLI setup is required. | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Qualify the removed command paths.
The install, uninstall, doctor, configuration, and MCP-selection entries are Hermes-specific paths. The generic commands still support Codex and Claude Code. As written, this bullet can imply that those commands were removed from the CLI. Rewrite it as “removed Hermes-specific support from ...”.
As per path instructions, documentation must be technically accurate against the current API and command behavior. The remaining command support is documented in the supplied release notes and crates/cli/README.md.
Proposed wording
- Removed Hermes Agent support from the NeMo Relay CLI, including the `hermes`
- shortcut, `run --agent hermes`, install, uninstall, doctor, configuration,
- MCP selection, and `/hooks/hermes` endpoint.
+ Removed Hermes-specific support from the NeMo Relay CLI, including the
+ `hermes` shortcut, `run --agent hermes`, and Hermes-specific install,
+ uninstall, doctor, configuration, MCP selection, and `/hooks/hermes` paths.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### Breaking Changes in 0.8 | |
| - Removed Hermes Agent support from the NeMo Relay CLI, including the `hermes` | |
| shortcut, `run --agent hermes`, install, uninstall, doctor, configuration, | |
| MCP selection, and `/hooks/hermes` endpoint. NeMo Relay is built into Hermes | |
| Agent, and Hermes Agent understands NeMo Relay plugin configurations. No | |
| separate observability plugin or Relay CLI setup is required. | |
| ### Breaking Changes in 0.8 | |
| - Removed Hermes-specific support from the NeMo Relay CLI, including the | |
| `hermes` shortcut, `run --agent hermes`, and Hermes-specific install, | |
| uninstall, doctor, configuration, MCP selection, and `/hooks/hermes` paths. | |
| NeMo Relay is built into Hermes Agent, and Hermes Agent understands NeMo Relay | |
| plugin configurations. No separate observability plugin or Relay CLI setup is | |
| required. | |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/about-nemo-relay/release-notes/index.mdx` around lines 66 - 73, Update
the breaking-changes bullet to state that Hermes-specific support was removed
from the listed paths, rather than implying the generic install, uninstall,
doctor, configuration, and MCP-selection commands were removed. Preserve the
existing Hermes shortcut, agent, and endpoint details while clearly indicating
that those commands still support Codex and Claude Code.
Source: Path instructions
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/nemo-relay-get-started/references/cli-try-now.md`:
- Line 9: Update the trial capability description in the CLI walkthrough to
remove the unqualified “read-only” claim, since the flow modifies user
configuration and creates directories. Describe the trial as confirmation-gated
instead, while preserving the existing “local,” “user-scoped,” and “limited to
the built-in Observability” qualifiers.
In `@skills/nemo-relay-get-started/SKILL.md`:
- Around line 24-31: Update the built-in integration flow in the skill so Hermes
Agent is explicitly stopped or handed off before the generic nemo-relay-install
and plugin/Observability steps; state that its built-in Relay support requires
no separate installation or configuration, while preserving the existing generic
installation and plugin progression for LangChain, LangGraph, Deep Agents, and
OpenClaw.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 6baf4afd-8a0f-4807-a8b8-da79a3752d92
📒 Files selected for processing (17)
crates/cli/src/configuration/mod.rscrates/cli/src/mcp/mod.rscrates/cli/tests/coverage/shared/config_tests.rsdocs/about-nemo-relay/release-notes/index.mdxdocs/getting-started/about.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/codex.mdxdocs/nemo-relay-cli/plugin-installation.mdxintegrations/coding-agents/codex/README.mdskills/nemo-relay-get-started/SKILL.mdskills/nemo-relay-get-started/evals/evals.jsonskills/nemo-relay-get-started/references/cli-try-now.mdskills/nemo-relay-install/evals/evals.jsonskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-install/references/maintained-integrations.md
📜 Review details
⏰ Context from checks skipped due to timeout. (44)
- GitHub Check: Rust / Package (macos-arm64)
- GitHub Check: Rust / Package (windows-arm64)
- GitHub Check: Python / Package (linux-musl-amd64)
- GitHub Check: Node.js / Package (linux-amd64)
- GitHub Check: Rust / Test (windows-amd64)
- GitHub Check: Rust / Package (linux-musl-amd64)
- GitHub Check: Node.js / Package (linux-musl-amd64)
- GitHub Check: Node.js / Package (macos-arm64)
- GitHub Check: Rust / Package (windows-amd64)
- GitHub Check: Rust / Package (linux-musl-arm64)
- GitHub Check: Python / Package (linux-arm64)
- GitHub Check: Rust / Test (windows-arm64)
- GitHub Check: Node.js / Package (linux-arm64)
- GitHub Check: Rust / Package (linux-arm64)
- GitHub Check: Rust / Package (linux-amd64)
- GitHub Check: Rust / Test (macos-arm64)
- GitHub Check: Node.js / Package (windows-amd64)
- GitHub Check: Python / Package (linux-amd64)
- GitHub Check: Node.js / Package (windows-arm64)
- GitHub Check: Node.js / Test (linux-arm64)
- GitHub Check: Node.js / Package (linux-musl-arm64)
- GitHub Check: Go / Test (linux-arm64)
- GitHub Check: Python / Package (windows-amd64)
- GitHub Check: Rust / Test (linux-arm64)
- GitHub Check: Python / Package (windows-arm64)
- GitHub Check: Python / Package (linux-musl-arm64)
- GitHub Check: Go / Test (windows-amd64)
- GitHub Check: Node.js / Package OpenClaw plugin
- GitHub Check: Node.js / Test (macos-arm64)
- GitHub Check: Python / Test (macos-arm64)
- GitHub Check: Python / Test (linux-amd64)
- GitHub Check: Rust / Test (linux-amd64)
- GitHub Check: Python / Package (macos-arm64)
- GitHub Check: Go / Test (windows-arm64)
- GitHub Check: Go / Test (macos-arm64)
- GitHub Check: Node.js / Test (windows-amd64)
- GitHub Check: Go / Test (linux-amd64)
- GitHub Check: Python / Test (windows-amd64)
- GitHub Check: Python / Test (windows-arm64)
- GitHub Check: Node.js / Test (linux-amd64)
- GitHub Check: Python / Test (linux-arm64)
- GitHub Check: Node.js / Test (windows-arm64)
- GitHub Check: Check / Run
- GitHub Check: Preview docs
🧰 Additional context used
📓 Path-based instructions (31)
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
MDX top-of-file SPDX comments must use {/* ... */} delimiters instead of HTML comment delimiters (Must-Fix)
**/*.mdx: In MDX files, top-of-file comments must use JSX comment delimiters ({/*and*/}); do not use HTML comments for MDX SPDX headers.
New or regenerated MDX files must use{/* ... */}for top-of-file SPDX comments.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdx
{docs,examples}/**/*
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update docs and examples.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdx
**/*
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
**/*: Format changed files with the language-native formatter before the final lint/test pass.
If dynamic plugin behavior changed, usemaintain-dynamic-pluginsand include the native SDK, worker protocol, Python SDK, docs, packaging, and Codecov surfaces in the validation plan.
If code changes alter APIs, bindings, commands, paths, packaging behavior, observability/adaptive semantics, or documented best practices, update any dependent maintainer or consumer skills in the same branch.
During iteration, preferuv run pre-commit run --files <changed files...>.
Before review or handoff, runuv run pre-commit run --all-files.
**/*: Use release tags in raw Rust-compatible SemVer without a leadingv; tags such asv0.1.0are prohibited.
Use branch prefixesfeat/,fix/,docs/,test/, orrefactor/according to the change purpose.
Every commit in a pull request must include a DCOSigned-off-by:sign-off.
Before submitting a pull request, ensure pre-commit hooks, relevant tests, target-specific builds, documentation updates, and a rebase on the latestmainare complete.
Use commit messages in the formtype: short description, with a valid type and a first line under 72 characters.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxskills/nemo-relay-install/references/maintained-integrations.mddocs/integrate-into-frameworks/about.mdxskills/nemo-relay-install/evals/evals.jsoncrates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rsskills/nemo-relay-get-started/SKILL.mddocs/nemo-relay-cli/basic-usage.mdxintegrations/coding-agents/codex/README.mdcrates/cli/tests/coverage/shared/config_tests.rsskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/evals/evals.jsondocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdxskills/nemo-relay-get-started/references/cli-try-now.md
docs/**/*
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If documentation examples or commands under
docs/change, run the targeted docs checks appropriate to the change.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdx
**/*.{md,mdx}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If links in documentation change, run
just docs-linkcheck.Use documented public APIs and stable wrapper commands in examples and user-facing documentation; do not rely on internal helpers.
**/*.{md,mdx}: Prefer the documented public API over internal shortcuts in documentation and examples.
Keep package names, repository references, and build commands current.
Contribution workflow documentation must require an issue before external contribution pull requests and note that NVIDIA contributors may use a GitHub or Linear issue.
Update entry-point documentation when examples or reading paths change.
Keep release-process and release-notes guidance in maintainer documentation such asRELEASING.md, rather than user-facing documentation pages orCHANGELOG.md.
Use stable user-facing wrappers at thescripts/root in documentation and examples; reference namespaced helper paths only for internal maintenance documentation.
When detailed dynamic plugin guides exist, keep Rust native plugin examples, Python worker plugin examples, andgrpc-v1protocol details on separate pages.
Dynamic plugin manifests in documentation and examples should usecompat.relay = ">=0.5,<1.0"unless deliberately narrower.
Render images, diagrams, tables, and other visual content at representative page widths, ensuring legibility and complete access without clipping; use responsive scaling, reflow, or overflow as appropriate and scope visual styling narrowly.
Dynamic plugin entry pages should link to native, worker, Rust example, Python example, and protocol pages when those pages exist.
Images, diagrams, tables, and custom visual content must remain legible and fully accessible at representative desktop and narrow page widths.
Release-policy documentation must point to GitHub Releases as the only release-history source of truth.
Runjust docswhen the documentation site changes; retain./scripts/build-docs.sh htmlas the compatibility wrapper.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxskills/nemo-relay-install/references/maintained-integrations.mddocs/integrate-into-frameworks/about.mdxskills/nemo-relay-get-started/SKILL.mddocs/nemo-relay-cli/basic-usage.mdxintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mddocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdxskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{md,mdx,py,go,js,ts}
📄 CodeRabbit inference engine (.agents/skills/maintain-observability/SKILL.md)
Examples and documentation must use each exporter's documented flush/deregister order before shutdown.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxskills/nemo-relay-install/references/maintained-integrations.mddocs/integrate-into-frameworks/about.mdxskills/nemo-relay-get-started/SKILL.mddocs/nemo-relay-cli/basic-usage.mdxintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mddocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdxskills/nemo-relay-get-started/references/cli-try-now.md
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant reference documentation when public behavior or APIs change.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdx
**/*.{rs,py,go,js,jsx,ts,tsx,c,h,html,md,mdx,toml}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include the appropriate SPDX copyright and Apache-2.0 license header in every source file.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxskills/nemo-relay-install/references/maintained-integrations.mddocs/integrate-into-frameworks/about.mdxcrates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rsskills/nemo-relay-get-started/SKILL.mddocs/nemo-relay-cli/basic-usage.mdxintegrations/coding-agents/codex/README.mdcrates/cli/tests/coverage/shared/config_tests.rsskills/nemo-relay-install/references/cli-install.mddocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdxskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{md,mdx,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
**/*.{md,mdx,rst}: Use title case consistently for technical documentation headings and table headers; avoid quotation marks, ampersands, and exclamation marks in headings, while preserving official product, event, research, and whitepaper title case.
Format code elements, commands, parameters, package names, expressions, directories, file names, and paths in monospace; represent path placeholders with angle brackets inside monospace.
Format UI buttons, menus, fields, and labels in bold, and separate consecutive UI navigation labels with>.
Use quotation marks for error messages and strings when appropriate, italics for newly introduced terms and publication titles, and plain text for keyboard shortcuts.
Represent GitHub repositories with owner/repository link text, such as[NVIDIA/NeMo](link), rather than generic repository wording.
Introduce every code block with a complete sentence; do not let a code block complete or interrupt the grammar of surrounding prose; use syntax highlighting when supported.
Keep inline method, function, and class references consistent with nearby documentation; omit empty parentheses in prose when no call is shown.
Use descriptive link text matching the destination title when possible; avoid raw URLs, generic anchors, long-sentence links, and unnecessary links that distract from procedures.
Ensure lists have a complete lead-in sentence, more than one item, no more than two levels, parallel construction, one idea or action per item, and appropriate punctuation; use bullets for unordered items and numbers for ordered tasks.
Format definition lists with a bold term followed by a complete, parallel, punctuated definition.
Use tables for reference information, decision support, compatibility matrices, and comparable choices; flag one-row tables, missing captions or lead-ins, sentence-case headers where title case is expected, unexplained empty cells, and code or links that would be clearer as prose.
Write procedure steps as imperative ...
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxskills/nemo-relay-install/references/maintained-integrations.mddocs/integrate-into-frameworks/about.mdxskills/nemo-relay-get-started/SKILL.mddocs/nemo-relay-cli/basic-usage.mdxintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mddocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdxskills/nemo-relay-get-started/references/cli-try-now.md
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/nemo-relay-cli/codex.mdxdocs/getting-started/quick-start/index.mdxdocs/about-nemo-relay/release-notes/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/plugin-installation.mdxdocs/getting-started/about.mdx
docs/about-nemo-relay/release-notes/{index,highlights,known-issues}.mdx
📄 CodeRabbit inference engine (.agents/skills/draft-release-notes/SKILL.md)
docs/about-nemo-relay/release-notes/{index,highlights,known-issues}.mdx: Update onlydocs/about-nemo-relay/release-notes/index.mdx,docs/about-nemo-relay/release-notes/highlights.mdx, anddocs/about-nemo-relay/release-notes/known-issues.mdxunless the release changes their route or entry points.
Preserve the existing MDX front matter and the JSX SPDX comment in the release-notes pages.
Files:
docs/about-nemo-relay/release-notes/index.mdx
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
skills/nemo-relay-install/references/maintained-integrations.mdskills/nemo-relay-get-started/SKILL.mdintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
skills/nemo-relay-install/references/maintained-integrations.mdskills/nemo-relay-get-started/SKILL.mdintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Spell
NVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Files:
skills/nemo-relay-install/references/maintained-integrations.mdskills/nemo-relay-get-started/SKILL.mdintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{md,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst}: Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.
Files:
skills/nemo-relay-install/references/maintained-integrations.mdskills/nemo-relay-get-started/SKILL.mdintegrations/coding-agents/codex/README.mdskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/references/cli-try-now.md
**/*.{rs,py,js,jsx,ts,tsx,go,c,h,cc,cpp,md,toml,yml,yaml,sh}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, documentation, scripts, and configuration files; the project is Apache-2.0.
Files:
skills/nemo-relay-install/references/maintained-integrations.mdcrates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rsskills/nemo-relay-get-started/SKILL.mdintegrations/coding-agents/codex/README.mdcrates/cli/tests/coverage/shared/config_tests.rsskills/nemo-relay-install/references/cli-install.mdskills/nemo-relay-get-started/references/cli-try-now.md
docs/integrate-into-frameworks/**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Update docs if activation or usage changes.
Files:
docs/integrate-into-frameworks/about.mdx
**/*.{yaml,yml,toml,json}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Maintain valid YAML, TOML, and JSON files; pre-commit hooks validate these formats.
Files:
skills/nemo-relay-install/evals/evals.jsonskills/nemo-relay-get-started/evals/evals.json
**/*.rs
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
**/*.rs: Any Rust change must runjust test-rust
Any Rust change must runcargo fmt --all
Any Rust change must runcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allfor all FFI work since it is Rust work
Runjust test-rustto validate FFI changes
Runcargo clippy --workspace --all-targets -- -D warningsto enforce strict linting on FFI workWhen Rust files changed as part of Go work, also run
cargo fmt --all,just test-rust, andcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allwhen Rust files are changed as part of Node work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files are changed as part of Node work
Runjust test-rustwhen Rust files are changed as part of Node work
**/*.rs: If any Rust code changed, always runjust test-rust.
If any Rust code changed, also runcargo fmt --all.
If any Rust code changed, also runcargo clippy --workspace --all-targets -- -D warnings.
For Rust changes headed for review, runcargo fmt --allandcargo clippy --workspace --all-targets -- -D warningseven if relying on pre-commit.
**/*.rs: Format Rust code with rustfmt defaults usingcargo fmt.
Runcargo clippy -- -D warnings; all Rust warnings must be treated as errors.
Use Rustsnake_casenaming conventions.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
{crates/**/src/**/*.rs,python/**/*.py}
📄 CodeRabbit inference engine (.agents/skills/maintain-dynamic-plugins/SKILL.md)
Do not add tests under
src; Rust tests belong in cratetests/trees, and Python SDK tests belong underpython/tests.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rs
**/*.{rs,py,go,js,ts}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If a language surface changed, always run that language's test target even when Rust core did not change.
**/*.{rs,py,go,js,ts}: When observability configuration or lifecycle is exposed, keep FFI and Python, Go, and Node.js binding-native config objects and subscriber/exporter methods aligned in logical knobs and semantics.
Require every OpenTelemetry endpoint to have a type and nonblank destination; resolveheader_envvalues at activation and reject missing, blank, or duplicate headers.
Concatenate layered ATOF sink, ATIF storage, and OpenTelemetry endpoint lists with higher-precedence entries first.
Preserve correct handling of mark events, start/end events, orphan cases, and span or trajectory fields derived from intended event data.
Run affected Rust tests andjust test-rustwhen event fields change; runjust test-python,just test-go, andjust test-nodewhen binding-native configuration or lifecycle changes.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
**/*.{rs,py,js,ts,tsx,go,java,kt,swift}
📄 CodeRabbit inference engine (.agents/skills/add-middleware/SKILL.md)
Add tests covering registration and duplicate names, deregistration and missing names, priority ordering, callback failure policy, scope-local inheritance and cleanup, event payload semantics, immutable mark and scope fields, and parity across affected bindings.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
**/*.{rs,py}
📄 CodeRabbit inference engine (AGENTS.md)
Use
snake_casenaming in Rust and Python.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
crates/**/*.rs: UseJson = serde_json::Valuein Rust-facing runtime APIs where existing code expects JSON payloads.
Treat Rust as the source of truth for runtime behavior; binding APIs should mirror Rust semantics unless a language-specific wrapper intentionally improves ergonomics.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
**/*.{rs,py,js,mjs,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Preserve the existing Tokio-based asynchronous model and callback/future lifetimes; do not unexpectedly block or hide async work in bindings.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
**/*.{rs,py,go,js,jsx,ts,tsx,c,h}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*.{rs,py,go,js,jsx,ts,tsx,c,h}: Run tests for every language affected by a change; changes to the core Rust crate require tests across all bindings.
UseSONAR_IGNORE_START/SONAR_IGNORE_ENDonly for documented false positives, keep ignored blocks minimal, explain them with a comment, and obtain reviewer sign-off.
Preserve the layered architecture in which Rust provides the core runtime and C FFI, PyO3, and NAPI provide bindings that mirror the full API surface.
Files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
**/SKILL.md
📄 CodeRabbit inference engine (AGENTS.md)
SKILL.mdfiles must start with YAML frontmatter containing at leastnameanddescription; they do not require SPDX headers.
Files:
skills/nemo-relay-get-started/SKILL.md
⚙️ CodeRabbit configuration file
**/SKILL.md: Do not flag SKILL.md files for missing SPDX headers. Skill entrypoints intentionally start with YAML frontmatter instead.
Verify that every SKILL.md keeps valid YAML frontmatter with at least name and description fields before the Markdown body.
Files:
skills/nemo-relay-get-started/SKILL.md
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update the relevant crate or package README when that package surface changes.
Update relevant package or crate
README.mdfiles when examples or binding guidance changes.
Files:
integrations/coding-agents/codex/README.md
**/{README.md,docs/index.md}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Update
README.mdordocs/index.mdwhen documentation entry points change.
Files:
integrations/coding-agents/codex/README.md
**/{test,tests}/**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
When adding functionality, include tests in the appropriate test files for each affected language binding.
Files:
crates/cli/tests/coverage/shared/config_tests.rs
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}
⚙️ CodeRabbit configuration file
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.
Files:
crates/cli/tests/coverage/shared/config_tests.rs
🧠 Learnings (1)
📚 Learning: 2026-08-03T19:55:03.931Z
Learnt from: afourniernv
Repo: NVIDIA/NeMo-Relay PR: 558
File: crates/pii-redaction/src/rampart/mod.rs:265-274
Timestamp: 2026-08-03T19:55:03.931Z
Learning: In NeMo Relay first-party plugin registration helpers, treat the documented duplicate-registration `PluginError::RegistrationFailed` result from `register_plugin` as success when registration is intended to be idempotent. Do not locally reclassify this as `PluginError::Conflict`; changing the classification requires a core-wide review of the public API and FFI behavior.
Applied to files:
crates/cli/src/mcp/mod.rscrates/cli/src/configuration/mod.rscrates/cli/tests/coverage/shared/config_tests.rs
🪛 SkillSpector (2.5.1)
skills/nemo-relay-get-started/SKILL.md
[warning] 37: [EA2] Autonomous Decision Making: Skill enables autonomous high-impact decisions without human-in-the-loop verification. Critical operations (destructive commands, financial transactions, data deletion) should require explicit user confirmation.
Remediation: Add human-in-the-loop confirmation for destructive, irreversible, or high-impact operations. Never auto-execute commands that modify files, send data, or alter system state.
(Excessive Agency (EA2))
🔇 Additional comments (16)
crates/cli/src/configuration/mod.rs (1)
77-77: 📐 Maintainability & Code QualityRun the required validation before handoff.
The configuration change matches the Hermes removal. The supplied context has no validation results. Run
just test-rust,cargo fmt --all,cargo clippy --workspace --all-targets -- -D warnings,just docs, anduv run pre-commit run --all-files.As per coding guidelines, Rust changes require the listed Rust checks, documentation changes require
just docs, and handoff requiresuv run pre-commit run --all-files.Source: Coding guidelines
crates/cli/src/mcp/mod.rs (1)
109-109: LGTM!crates/cli/tests/coverage/shared/config_tests.rs (1)
627-640: LGTM!Also applies to: 2191-2240
docs/about-nemo-relay/release-notes/index.mdx (1)
68-73: LGTM!skills/nemo-relay-get-started/evals/evals.json (1)
64-69: LGTM!Also applies to: 81-81, 138-145
skills/nemo-relay-get-started/references/cli-try-now.md (1)
74-86: LGTM!Also applies to: 97-104, 114-127, 146-151, 172-172, 198-207
skills/nemo-relay-install/evals/evals.json (1)
87-95: LGTM!skills/nemo-relay-install/references/cli-install.md (1)
25-26: LGTM!Also applies to: 89-89
skills/nemo-relay-install/references/maintained-integrations.md (1)
9-12: LGTM!Also applies to: 26-28
docs/getting-started/about.mdx (1)
65-68: LGTM!docs/getting-started/quick-start/index.mdx (1)
63-63: LGTM!Also applies to: 74-75
docs/integrate-into-frameworks/about.mdx (1)
52-55: LGTM!docs/nemo-relay-cli/basic-usage.mdx (1)
15-16: LGTM!Also applies to: 28-28, 63-63, 78-82, 93-113, 433-434, 479-479, 488-495, 529-529
docs/nemo-relay-cli/codex.mdx (1)
159-160: LGTM!docs/nemo-relay-cli/plugin-installation.mdx (1)
3-24: LGTM!Also applies to: 41-45, 53-56, 65-76, 118-120, 131-131, 149-150, 202-202, 204-216, 223-224, 232-235, 255-255, 271-293, 322-325
integrations/coding-agents/codex/README.md (1)
76-77: LGTM!
Signed-off-by: Will Killian <wkillian@nvidia.com>
afourniernv
left a comment
afourniernv
left a comment
There was a problem hiding this comment.
Approving: I did not find an unintended regression in the supported Claude, Codex, Switchyard, packaging, or native Hermes integration paths. One additional non-blocking cleanup item: cargo machete --with-metadata reports the CLI's direct chrono dependency as unused now that the Hermes trust implementation has been removed.
| NeMo Relay 0.8 removes Hermes Agent from the Relay CLI. The `nemo-relay hermes` | ||
| shortcut, `nemo-relay run --agent hermes`, Hermes install, uninstall, doctor, | ||
| configuration, MCP selection, hook forwarding, and `/hooks/hermes` endpoint are | ||
| no longer supported. Relay configuration under `[agents.hermes]` is also |
There was a problem hiding this comment.
Could we make the remediation explicit here? With FileAgentsConfig now using deny_unknown_fields, an existing [agents.hermes] section prevents unrelated config-resolving commands, including Claude and Codex runs, from starting. Something like “Remove the [agents.hermes] section before upgrading” would make this actionable. This is non-blocking for me.
| for hook_event_name in ["SessionStart", "Stop"] { | ||
| let response = client | ||
| .post(format!("{url}/hooks/hermes")) | ||
| .post(format!("{url}/hooks/codex")) |
There was a problem hiding this comment.
Could we retain the deleted serve_listener_observability_plugin_records_non_hermes_hooks coverage, renamed for the supported hosts? This replacement proves the full plugin export path for Codex, but no surviving test drives Claude hooks through the complete hook → observability plugin → file-export path. Not blocking, but the cross-host check is useful in a teardown this broad.
| #[cfg(test)] | ||
| use crate::hooks::generated_hooks; | ||
| #[cfg(test)] | ||
| #[cfg(test)] |
There was a problem hiding this comment.
nit: This duplicates the preceding #[cfg(test)].
2 participants
Overview
Remove Hermes Agent support from the NeMo Relay CLI for the 0.8 release while preserving the runtime APIs and metadata used by Hermes Agent's native in-process integration.
Details
hermesshortcut,run --agent hermes, Hermes install/uninstall/doctor/config flows, MCP selection, hook forwarding, discovery, JSON output, and/hooks/hermesendpoint.This is an intentional breaking change for NeMo Relay 0.8. Removed commands and
[agents.hermes]configuration do not have compatibility shims.Validation:
just test-rustcargo clippy --workspace --all-targets -- -D warningsjust docsjust docs-linkcheckuv run pre-commit run --all-filesWhere should the reviewer start?
Start with
crates/cli/src/agents/mod.rsfor the supported-agent reduction, then reviewcrates/cli/tests/cli_tests.rsfor rejected Hermes entry points anddocs/reference/migration-guides.mdxfor the 0.8 migration contract.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Breaking Changes
Documentation