You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(review): keep the reviewer roster limited to collaborators #5549
As an OpenShell maintainer investigating Review Readiness failures, I need the reviewer roster to contain only accounts GitHub can request so valid review requests succeed.
Problem Statement
REVIEWERS.md includes non-collaborators. GitHub rejects a reviewer-request batch containing one of these accounts with HTTP 422. A request for only 2000krysztof on #5540 confirmed the collaborator restriction.
Impact / Why This Matters
An ineligible roster entry blocks requests to eligible reviewers. Roster changes need a check that catches this before merge.
Acceptance Criteria
Remove every current non-collaborator from REVIEWERS.md, preserving the category definitions and eligible reviewers.
Branch Checks validates every roster handle against all pages of GitHub's repository collaborator list, reporting sorted offending handles and failing on lookup errors.
Read, triage, and outside collaborators remain eligible; write access is not required.
Offline tests cover eligible accounts, non-collaborators, pagination, and lookup failures.
Reproduction Steps
Select a non-collaborator listed in OpenShell's reviewer roster.
Request that account as a PR reviewer.
Observe HTTP 422: “Reviews may only be requested from collaborators.”
Environment
Repository: NVIDIA/OpenShell
Integration: GitHub Review Readiness and reviewer roster
This replaces #5539 and #5540 with a smaller roster cleanup and validation check.
Repository collaborator checks during the investigation returned 404 for the selected roster entries ChristianZaccaria and 2000krysztof. The six other selected accounts passed the collaborator check. A separately requested review from SDAChess approved the same head, and OpenShell / Maintainer Approval is green. The approval does not resolve the invalid automatic reviewer-request batch.
The workflow loads REVIEWERS.md and its routing helper from the default branch. The cleanup and membership validation described in this issue therefore need to land on main before rerunning Review Readiness on #5637. This reproduces the existing issue's scope; the dependency-only PR does not need to change reviewer policy.
Activity
alangou commentedon Nov 17, 2026
Additional confirmed case: PR #5637, head
f7f1c30e37b52bcc8baca7a586a72f92a4ee371e.With
area:buildandtopic:security, Review Readiness fails while requesting reviewers. GitHub returns HTTP 422: "Reviews may only be requested from collaborators."Repository collaborator checks during the investigation returned 404 for the selected roster entries
ChristianZaccariaand2000krysztof. The six other selected accounts passed the collaborator check. A separately requested review from SDAChess approved the same head, andOpenShell / Maintainer Approvalis green. The approval does not resolve the invalid automatic reviewer-request batch.The workflow loads
REVIEWERS.mdand its routing helper from the default branch. The cleanup and membership validation described in this issue therefore need to land onmainbefore rerunning Review Readiness on #5637. This reproduces the existing issue's scope; the dependency-only PR does not need to change reviewer policy.