Skip to content

test(e2e): port provider tests from e2e/rust to testkit #5656

Open

Description

@matthewgrossman

User Story

As a maintainer retiring e2e/rust, I want the provider tests on testkit, so they run on every conformance row and the legacy files can be deleted.

Description

Conformance destinations are under tests/suites/conformance/src/.

Legacy test Action Destination Notes
provider_files::provider_file_open_update_and_detach port providers.rs
provider_auto_create::auto_created_provider_credential_available_in_sandbox port providers.rs Separate CLI path (auto-created providers).
service_bearer_passthrough::service_bearer_passthrough_preserves_authorization_header port tests/suites/features/service-exposure New feature package; other service-exposure tests can join it later.

Helpers this PR adds

  • testkit: create_provider(..) and install_provider(..) take .config(..) (--config). No provider-delete cleanup poll: testkit deletes sandboxes before providers.
  • cx.service_get reaches exposed services through the gateway endpoint, with the service URL's authority as Host. Environments need no extra routing.
  • testkit: testkit::Profile and testkit::Credential, a typed provider profile builder, so tests stop writing profile YAML with format!. It covers id, display_name, category, credentials (name, env_vars, required, auth_style, header_name, refresh), discovery, endpoints (configured with policy::Endpoint, which gains enforce() and path()) and binaries. profile.to_yaml() renders it through openshell-providers for import_profile and install_provider. This PR converts conformance/src/providers.rs and features/keycloak-provider-refresh; credential_gating.rs is converted in test(e2e): port network, L7 and policy-update tests from e2e/rust to conformance #5665 after this merges.

Files deleted

provider_auto_create.rs, provider_files.rs, service_bearer_passthrough.rs.

Context

Definition of Done

  • Every test in the table is ported as listed.
  • The listed files are deleted, and every reference to them in wrapper scripts, tasks/*.toml and nextest config is removed.
  • Each ported test runs on at least the drivers its legacy lane covered; features/service-exposure has rows in .github/workflows/e2e-suites.yml.

Part of #5281. Planned in #5297 (PR3, provider half).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

topic:testingUnit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions