fix(helm): build chart dependencies before lint#1947
Merged
Conversation
elezar
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
elezar
force-pushed
the
no-issue-helm-lint-deps-el
branch
from
76c3bef to
00e77f8
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
no-issue-helm-lint-deps-el
branch
from
00e77f8 to
b8dc44d
Compare
6 tasks
pimlock
approved these changes
Jun 17, 2026
TaylorMutch
reviewed
Jun 18, 2026
TaylorMutch
left a comment
TaylorMutch
left a comment
Collaborator
There was a problem hiding this comment.
why was this needed? There are no chart dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build Helm chart dependencies before running chart lint and helm-unittest so optional subchart dependencies are resolved consistently.
Related Issue
None.
Changes
helm dependency build deploy/helm/openshellbeforehelm lint.helm dependency build deploy/helm/openshellbeforehelm unittest.Testing
mise run pre-commitpassesmise run helm:lintpassesmise run helm:testpassesNote:
mise run pre-commitwas run and failed in unrelatedrust:lintoncrates/openshell-server/src/lib.rs:347due to an existing unusedshutdown_txwarning promoted to an error.Checklist