Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Docker supervisor always used host networking, which Docker Desktop Enhanced Container Isolation (ECI) prohibits. Add automatic supervisor networking: inspect the existing workload's runtime and select bridge for
sysbox-runc, retaining host mode for ordinary workloads. Standard Desktop bridge setups derive a gateway callback endpoint without creating a diagnostic container.Related Issue
Closes #4015.
Implementation and this draft PR were directly requested by the maintainer. The issue does not yet carry acceptance or agent request labels; those labels were left unchanged.
Changes
supervisor_network_mode = "auto" | "host" | "bridge"; sandbox-supplied driver config cannot select this mode.network=none, capability removal, and no-new-privileges on the workload boundary.grpc_endpoint.mise run e2e:dockersuite without a dedicated networking task or test. The E2E harness uses automatic selection with no networking-mode switches; host runs also discover the callback endpoint automatically, while containerized CI keeps its existing callback address.Testing
mise run pre-commitpasses, including workspace Clippy and formatting, Markdown/Mermaid, license, Helm, proto, Python, and TypeScript checks.mise run testpasses.mise run e2e:dockerpasses against local Docker Engine on Linux arm64 with automatic networking and endpoint selection, using branch-built supervisor and sandbox images. Existing CLI conformance and Rust E2E scenarios cover host aliases, corporate proxies, approved egress, interactive access, lifecycle and reconnect behavior. No dedicated networking test or task is added. Bridge operation was also validated earlier; Desktop ECI qualification remains pending.mise run ci: fails in unrelated Go SDK gateway discovery tests (TestListGateways_MultipleGateways,TestListGateways_EmptyDirs,TestListGateways_ActiveStatus) because this machine has a configured system gateway under/etc/openshell/gateways. The tests count that additional gateway. No Go source changed.Checklist