Repository navigation
Conversation
|
This pull request has had no activity for 14 days and is now marked stale. |
7d181e5 to
613b95b
Compare
Maintainer list changeGains approval rights: Confirm every change is intended. Anyone listed here can single-handedly satisfy |
|
/ok to test 613b95b |
|
Label |
|
Holding this until the conformance program lands, via either #5138 or its restack in #5249. Both PRs move the conformance suites from
The three tests passed in all five conformance lanes on the current head ( |
613b95b to
4e45045
Compare
|
/ok-to-test 4e45045 |
4e45045 to
7b5461e
Compare
Move the three create_with_upload tests from e2e/rust into the conformance suite. They read each uploaded file back and compare exact content, check the nested file and that the directory is not flattened, and use the default upload path and the target's default image. Remove the legacy test and its now-unused SandboxGuard helpers. Signed-off-by: Evan Lezar <elezar@nvidia.com>
7b5461e to
dd03ff9
Compare
|
/ok-to-test dd03ff9 |
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
left a comment
There was a problem hiding this comment.
Thanks, this looks good. The checks are stronger than the originals (exact content, the nested file, no flattening), and cleanup is registered before create. I pushed a small follow-up that uses ExecOutput::expect_stdout for the file checks instead of a local helper.
|
/ok to test 0ddee06 |
Summary
Move the three
sandbox create --uploadtests from the legacy e2e crate into the testkit conformance suite. Upload on create isn't driver-specific, so the tests run against any prepared gateway.Related Issue
Closes #5599. Part of #5281.
Changes
tests/suites/conformance/src/create_upload.rswith three#[testkit::test]tests, keeping the original names so filters keep working:create_with_upload_directory_preserves_source_basename,create_with_multiple_uploadsandcreate_with_upload_single_file. Add acreate-uploadrow to the conformance README.sandbox create.--no-git-ignoreand used the e2e test image.--uploadtogether with a command, so each test checks the files oncecreatereturns.e2e/rust/tests/upload_create.rsand the legacy harness helpers only it used.file_transfer.rscovers the separatesandbox uploadcommand. Nothing else on main coverscreate --uploadon a real sandbox.Testing
Checklist