Skip to content

test(conformance): migrate create-upload tests to testkit - #4606

Merged
elezar merged 2 commits into
NVIDIA:mainfrom
politerealism:test/3954-create-upload-stories/politerealism
Nov 16, 2026
Merged

elezar merged 2 commits into
NVIDIA:mainfrom
politerealism:test/3954-create-upload-stories/politerealism

Conversation

@politerealism

@politerealism politerealism commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Move the three sandbox create --upload tests from the legacy e2e crate into the testkit conformance suite. Upload on create isn't driver-specific, so the tests run against any prepared gateway.

Related Issue

Closes #5599. Part of #5281.

Changes

  • Add tests/suites/conformance/src/create_upload.rs with three #[testkit::test] tests, keeping the original names so filters keep working: create_with_upload_directory_preserves_source_basename, create_with_multiple_uploads and create_with_upload_single_file. Add a create-upload row to the conformance README.
  • Read each uploaded file back and compare exact content. The originals matched the printed output of sandbox create.
  • Check the nested file in the directory test, and that the directory isn't flattened. Check each destination separately in the multiple-uploads test.
  • Use the default upload path and the target's default image. The originals passed --no-git-ignore and used the e2e test image.
  • The CLI rejects --upload together with a command, so each test checks the files once create returns.
  • Delete e2e/rust/tests/upload_create.rs and the legacy harness helpers only it used.

file_transfer.rs covers the separate sandbox upload command. Nothing else on main covers create --upload on a real sandbox.

Testing

  • Build, clippy, fmt and the pre-commit hook pass.
  • Not run against a gateway locally. The E2E jobs have not run in CI on this head yet. Not run on macOS.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 14 days and is now marked stale.

@github-actions github-actions Bot added the state:stale Inactive item at risk of automatic closure. label Oct 30, 2026
@elezar
elezar force-pushed the test/3954-create-upload-stories/politerealism branch from 7d181e5 to 613b95b Compare November 3, 2026 17:11
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Maintainer list change

Gains approval rights:

Confirm every change is intended. Anyone listed here can single-handedly satisfy OpenShell / Maintainer Approval.

@elezar
elezar changed the base branch from codex/4119-suite-layout to main November 3, 2026 17:13
@elezar elezar changed the title test(conformance): migrate create-upload tests to file_transfer stories test(conformance): migrate create-upload tests to testkit Nov 3, 2026
@elezar

elezar commented Nov 3, 2026

Copy link
Copy Markdown
Member

/ok to test 613b95b

@elezar elezar added the test:e2e Requires end-to-end coverage label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Label test:e2e applied for 613b95b. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@github-actions github-actions Bot removed the state:stale Inactive item at risk of automatic closure. label Nov 4, 2026
@elezar

elezar commented Nov 4, 2026

Copy link
Copy Markdown
Member

Holding this until the conformance program lands, via either #5138 or its restack in #5249.

Both PRs move the conformance suites from tests/suites/conformance/tests/*.rs into a library under src/, registered with a mod line in src/lib.rs, and rewrite the suite README. After one of them merges, this PR needs to:

  • move create_upload.rs into src/ and add mod create_upload; to src/lib.rs
  • redo the create-upload row in the README
  • recheck the test names against the new nextest naming

The three tests passed in all five conformance lanes on the current head (613b95b73), so this is a layout change only. I'll rebase once the program merges.

@elezar
elezar force-pushed the test/3954-create-upload-stories/politerealism branch from 613b95b to 4e45045 Compare November 5, 2026 13:44
@elezar

elezar commented Nov 5, 2026

Copy link
Copy Markdown
Member

/ok-to-test 4e45045

@elezar elezar added area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. topic:testing Unit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure. labels Nov 5, 2026
@elezar
elezar force-pushed the test/3954-create-upload-stories/politerealism branch from 4e45045 to 7b5461e Compare November 13, 2026 13:12
Move the three create_with_upload tests from e2e/rust into the conformance
suite. They read each uploaded file back and compare exact content, check the
nested file and that the directory is not flattened, and use the default
upload path and the target's default image. Remove the legacy test and its
now-unused SandboxGuard helpers.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the test/3954-create-upload-stories/politerealism branch from 7b5461e to dd03ff9 Compare November 13, 2026 15:19
@elezar

elezar commented Nov 13, 2026

Copy link
Copy Markdown
Member

/ok-to-test dd03ff9

@elezar
elezar enabled auto-merge November 13, 2026 15:22
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

@matthewgrossman matthewgrossman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. The checks are stronger than the originals (exact content, the nested file, no flattening), and cleanup is registered before create. I pushed a small follow-up that uses ExecOutput::expect_stdout for the file checks instead of a local helper.

@matthewgrossman

Copy link
Copy Markdown
Member

/ok to test 0ddee06

@elezar
elezar added this pull request to the merge queue Nov 16, 2026
Merged via the queue into NVIDIA:main with commit 92d569b Nov 16, 2026
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build CI/CD workflows, releases, build targets, packaging, and artifact publication. test:e2e Requires end-to-end coverage topic:testing Unit, integration, regression, conformance, E2E tests, coverage, flakes, and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(e2e): port sandbox create --upload tests from e2e/rust to conformance

3 participants