Repository navigation
feat(gateway): broker stable sandbox SPIFFE provider tokens #4732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+5,467
−308
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a5b08ad
feat(gateway): broker stable sandbox SPIFFE provider tokens
drew 7410286
refactor(gateway): rename SPIFFE delegation configuration
drew 22456ba
fix(provider): reuse broker channels and attribute grant failures
drew 4a8efe1
test(provider): satisfy broker logging lint checks
drew 4686ac0
fix(provider): harden broker caching and deployment prerequisites
drew de6dd89
refactor(identity): extract SPIRE sandbox identity adapter
drew e33dd11
refactor(identity): move shared SPIFFE types out of core
drew 16f61f5
fix(supervisor): follow the sandbox reconciler leader (#4853)
drew 3593be0
chore(sdk): drop regenerated frozen Go bindings
TaylorMutch 626feae
chore: integrate main into SPIFFE token broker
TaylorMutch 100986e
chore: merge latest main into SPIFFE token broker
TaylorMutch 7f88a02
test(spiffe): verify provider tokens across supervisor failover
TaylorMutch 0d71cfd
chore: merge main into SPIFFE token broker
TaylorMutch 3f939a0
feat(crypto): verify TLS peers by SPIFFE identity
TaylorMutch 89aad0f
feat(spiffe): use Broker API for sandbox identity issuance
TaylorMutch 17c8b7b
test(spiffe): verify broker authorization and credential rotation
TaylorMutch 4532524
docs(spiffe): clean up broker troubleshooting and test wording
TaylorMutch 8a2ef16
chore: merge main into SPIFFE token broker
TaylorMutch d7b0c95
chore: merge main into SPIFFE token broker
TaylorMutch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: the gateway's own Workload API socket now comes from two places: this field for the Broker mTLS client, and
OPENSHELL_GATEWAY_SPIFFE_WORKLOAD_API_SOCKETfor the RFC 8693 client assertion (provider.rs:4779). Startup checks neither against the other. The driver's refusal ofprovider_spiffe_workload_api_socket_pathwithsupervisor_topology = "gateway"is also gone (driverconfig.rs:610), so a shared topology withoutspiffe_brokerstarts cleanly and fails every grant at request time. One source for the socket, plus a refusal whenspiffe_brokeris missing, would catch both at startup.