Repository navigation
Conversation
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 14, 2026 01:30
8 of 11 tasks
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
enabled auto-merge
November 14, 2026 04:55
github-actions
Bot
requested review from
SDAChess,
TaylorMutch,
elezar,
johntmyers,
krishicks,
matthewgrossman and
pimlock
November 14, 2026 04:57
2 of 15 tasks
Contributor
|
/ok to test 09b8d53 |
Contributor
|
/ok to test 2853ff2 |
Contributor
|
/ok to test 4449a61 |
Check effective write or admin access before rejecting an account omitted from the collaborator list. Keep public read access and lookup errors rejected, with regression tests and matching contributor guidance. Signed-off-by: Adrien Langou <alangou@nvidia.com>
alangou
force-pushed
the
fix/5549-reviewer-roster-validation/purp
branch
from
November 17, 2026 14:30
4449a61 to
d6d57f0
Compare
Contributor
|
/ok to test d6d57f0 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove ineligible reviewer-roster entries and validate the roster in Branch Checks before merge. Preserve listed read, triage and outside collaborators, and recognize accounts with confirmed effective write or admin access.
Why
Maintainers need automatic review requests to reach eligible reviewers instead of failing an entire batch with HTTP 422. The existing roster contains accounts GitHub cannot request.
The validation must also recognize effective access. In the Actions diagnostic, an account was absent from both membership APIs while its permission response reported
admin. GitHub documents write access as sufficient for requesting a review, and the permission endpoint reports the highest effective base permission. Publicreadpermission alone does not establish collaborator membership.Related Issue
Closes #5549.
Changes
Reviewer Rosterjob to Branch Checks for PR mirrors and merge groups. Reuse the existing roster parser and consume all collaborator-list pages.writeoradminbase permission. Reject unlistedreadornone; fail on lookup errors or malformed responses. Custom role names do not establish eligibility.Testing
git diff --checkpass.Reviewer Rosterjob accepted all 17 accounts.Checklist