Repository navigation
Conversation
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Karthik-Chowdary
left a comment
There was a problem hiding this comment.
Autonomous, non-approving review of head 1488c4d251e8844065c37bd83b075f93beff251d.
The 197 offline labeling tests pass with the documented warnings-as-errors command. I also passed actual git diff output through prepare_snapshot, rather than constructing the diff headers by hand.
Recovery gap for unquoted paths containing spaces (tasks/scripts/label_issue_evidence.py:772-780): before this PR, an omitted patch stayed partial. The new fallback still leaves it partial for an ordinary path such as space name.py, even when the raw diff contains a complete hunk. Git emits --- a/space name.py<TAB> and +++ b/space name.py<TAB>; _diff_path retains that framing tab on an unquoted path, so the recovered identity becomes space name.py\t and cannot match the files endpoint filename. The diagnostic reports No complete raw diff patch for file identity and counts; a plain-name control recovers successfully.
Separating the tab delimiter before decoding the path makes both Git-generated cases pass, and the 197 existing tests remain green. Could the recovery tests include the unquoted-space form as well as the quoted UTF-8 form? This is a remaining fallback coverage gap, not a new unsafe-write behavior or a regression from the base. No live labels were changed; this comment is not a merge approval.
Summary
Recover missing or incomplete
/label-issuepatches from GitHub's raw PR diff. Complete evidence can proceed through the existing preview and apply checks; failed recovery continues to block label writes.Related Issue
Closes #5583
Relates to #5151 and #5276.
Changes
/label-issuecommand reference.The existing 2 MiB response bound applies. Binary or metadata-only changes without text hunks remain partial; classifier context budgeting is separate.
Release Notes
Testing
uv run --no-project --offline --python /usr/bin/python3 python -W error -m unittest discover -s tasks/scripts -p 'label_issue*_test.py' -q.crates/openshell-server/src/grpc/policy.rs) and feat(api)!: model CPU and memory as typed compute resource requirements #3012 (sdk/go/proto/openshellv1/openshell.pb.go), with complete files coverage. No live labels changed.git diff --checkpass for the changed files.Checklist