Repository navigation
Conversation
…ushes configuration Add the ubuntu-docker-rootful-config-push tmachine environment. Its setup playbook, config-delivery.yaml, writes config_delivery_mode to the gateway overrides that the deb, rpm and binaries installers apply, and publishes the mode as OPENSHELL_TEST_CONFIG_DELIVERY_MODE. A push gateway lets a supervisor without push support keep polling, so the conformance suite passes in either mode. The new config-push feature suite fails unless the published mode is push and a new sandbox's supervisor reports a pushed-configuration session. E2E Suites runs the conformance family and the config-push suite in the new environment with the deb installer. mise run e2e:testkit:push runs both against a local Docker gateway in push mode. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
The supervisor logs a pushed-configuration session only when the gateway accepted it with push enabled, so the config-push suite no longer also requires an OPENSHELL_TEST_CONFIG_DELIVERY_MODE variable. The environment's playbook, now config-push.yaml, sets push without a mode input, since polling is going away, and no longer writes an [openshell] table that a second overrides writer could duplicate. The test retries a failed `openshell logs` call until its timeout. e2e:testkit:push runs the push check before the conformance suite, so a conformance failure can't hide whether push was on. The TESTING.md section moves next to the tmachine runner docs instead of capturing the feature suite paragraphs that follow the gateway overrides section. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 16, 2026 21:43
…teway-push-1d7bb5 Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com> # Conflicts: # .github/workflows/e2e-suites.yml # tests/suites/features/Cargo.toml # tests/tmachine/config.nix
|
🌿 Preview your docs: https://nvidia-preview-pr-5622.docs.buildwithfern.com/openshell |
pimlock
marked this pull request as draft
November 16, 2026 21:48
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
A gateway built from this tree rejects unknown config fields and its supervisor always supports push, so the push conformance row already runs with push on unless the override file stops being merged. The separate suite cost a VM per E2E run for that one case. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
… file Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
marked this pull request as ready for review
November 16, 2026 23:54
|
Label |
6 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs the full conformance suite in CI against a gateway with
config_delivery_mode = "push", ahead of making push the default in #4498.Related Issue
Refs #4498. No issue required: test and CI coverage only, no product behavior change.
Changes
ubuntu-docker-rootful-config-push:ubuntu-docker-rootfulplusplaybooks/config-push.yaml, which writesconfig_delivery_mode = "push"to/etc/openshell-test/gateway-overrides.toml. The deb, rpm and binaries installers already merge that file..github/workflows/e2e-suites.yml:conformancein the new environment with the deb installer.mise run e2e:testkit:pushruns conformance against a local Docker gateway withOPENSHELL_CONFIG_DELIVERY_MODE=push, for hosts without KVM.Nothing asserts push is in use. A typo in the setting fails gateway startup (unknown fields are rejected), and supervisors built from this tree always support push, so push is off only if the override file stops being merged. A separate evidence suite was tried and dropped as not worth a VM per E2E run.
Scope notes:
[openshell] version = 2.e2e/rust/tests/config_push.rswithe2e:rust:push, can go when feat(config)!: make push config delivery the default and remove supervisor polling #4498 makes push the default.Testing
mise run pre-commitpassesLocal results, before merging main:
ubuntu-docker-rootful-config-push+ deb: conformance 22/22 pass.config_push=true.The new CI row runs on amd64 and has not run in CI yet.
Checklist