Repository navigation
test(conformance): check that a cached policy DNS address takes new connections - #5651
Draft
matthewgrossman wants to merge 6 commits into
Draft
matthewgrossman wants to merge 6 commits into
matthewgrossman wants to merge 6 commits into
Conversation
…ections A client that keeps a policy DNS address past the mapping's lifetime is refused on a host the policy allows (#4674). Add a features suite that resolves host.openshell.internal, connects, waits 45 s, and connects again to the same address, and run it on the Docker and Podman rows. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Member
Author
|
/ok to test 24a4e09 |
|
Label |
…ance Policy DNS runs in the sandbox runtime every driver uses, so the test belongs in conformance and runs on every conformance row, including k3s and k3s-ha. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test 7179707 |
The move to conformance restored the workflow and the features lockfile from a newer main. Restore them from the branch base so the PR only adds the conformance test. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test 980b957 |
The host alias mapping expires exactly 30 s after the lookup, so 33 s is enough to show the expiry and keeps the test shorter. The comment explains the choice. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test 9c71fa7 |
…cached-address/matthewgrossman Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test 449646d |
…test The fix for #4674 documents that a cached policy DNS address keeps taking new connections after its mapping expires. Cite that promise and explain the 33 s wait against it. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Member
Author
|
/ok to test 0505575 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a conformance test for #4674: a client that keeps a policy DNS address, as libcurl and the JDK do, can still open new connections to it after its mapping expires. #5650 fixed this and documented it in the network rules page; this test checks it on every driver, including Kubernetes, where #4674 was reported.
Related Issue
Refs #4674 (closed by the fix in #5650).
Changes
policy_dnswithcached_address_takes_new_connections. It resolveshost.openshell.internalin a sandbox, connects to the synthetic address, waits 33 s without a new lookup, and connects again. It also checks that a synthetic address policy DNS never handed out is refused.Why 33 s
host.openshell.internala mapping that expires exactly 30 s after the lookup (MAX_MAPPING_TTLincrates/openshell-supervisor-network/src/policy_dns/mod.rs), with no grace period.Testing
cargo clippyandcargo fmt --checkon the conformance crateubuntu-docker-rootfuland Branch E2E on every conformance row and host lane failed only this test, at the second connection, withPermissionError: [Errno 13] Permission deniedubuntu-docker-rootfulshould passChecklist