Repository navigation
build(windows): default to static CRT and pinned Z3 packages - #5654
shailendra-nv wants to merge 15 commits into
Conversation
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/windows-ci |
|
🌿 Preview your docs: https://nvidia-preview-pr-5654.docs.buildwithfern.com/openshell |
|
/ok to test bb8c4f9 |
Windows ARM64 CI: ✅ passedCommit
|
Compatibility review (advisory)Unaddressed breaking changes Windows remote-test invocations using 1. cli — NOT ACKED
2. configuration — NOT ACKED
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test ed4d29d |
|
/windows-ci |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 7200fce |
|
/windows-ci |
Compatibility review (advisory)Unaddressed breaking changes Existing Windows MXC automation using 1. cli — NOT ACKED
2. configuration — NOT ACKED
Review details
Advisory review; publication gates are unchanged. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 27de545 |
|
/windows-ci |
|
Addressed the compatibility review in 27de545:
The static-only package contract implements the requested removal of the Z3 DLL and Visual C++ redistributable requirements. The real MXC suite passed all seven default scenarios plus HTTPS CA, with zero skips, before this argument/documentation-only follow-up. Windows CI is being refreshed for the new head. |
Compatibility review (advisory)Unaddressed breaking changes The documented Windows Z3 override no longer selects shared Z3, so existing offline or CMake-free build automation can fail. SDKs, runtime APIs, CLI, Helm, policy, and persisted state are unchanged. 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
|
The latest review confirms that Baseline context:
The package-construction change is intentional: embedding CRT and Z3 removes the destination machine's redistributable and Z3-DLL requirements. |
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 10b5a55 |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 5a3ff56 |
|
/windows-ci |
Compatibility review (advisory)Unaddressed breaking changes Windows 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
Compatibility review (advisory)Unaddressed breaking changes Windows 1. configuration — ACKED
Review details
Advisory review; publication gates are unchanged. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test b61b07a |
|
/windows-ci |
|
Updated for the current implementation in 79cb5d6: Windows tasks and CI now default to static CRT/Z3, using the published, digest-pinned Z3 5.1.0 Compiler clarification: "GitHub default" referred specifically to the selected Visual Studio 2026 toolchain on the hosted |
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 5d2febf |
|
/windows-ci |
|
@codex security review |
|
Codex review is not enabled for this repo. Please contact the admins of this repo to enable Codex. |
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
Signed-off-by: shailendras <shailendras@nvidia.com>
|
/ok to test 79cb5d6 |
|
/windows-ci |
Summary
Build Windows packages with static CRT in all four OpenShell executables and static Z3 5.1.0 in the gateway by default. Normal builds download and cache digest-pinned static libraries from OpenShell's Z3 GHCR package; source builds occur only when requested or the package is unavailable.
Related Issue
Closes #5653
The author has verified
MAINTAINaccess to NVIDIA/OpenShell; the issue does not have an acceptance label.Changes
/MTZ3 packages through an explicitpublish_z3mode in the existing Windows MSVC workflow. This dependency build is separate from ordinary CI.tasks/windows-z3.json. Native PowerShell downloads packages without Docker, ORAS, or GitHub credentials, verifies their files/version/architecture/runtime/compiler baseline, and caches one extracted copy outside Cargo pruning.OPENSHELL_WINDOWS_STATIC_RUNTIME=0as the explicit legacy shared mode, including shared DLL staging and-Z3DllPathcompatibility. An inherited shared override in default static mode produces a migration warning and selects the pinned static package.The dependency archives are build inputs, not files added to distributed OpenShell ZIPs. Updating embedded CRT or Z3 code requires rebuilding the affected dependency package/executables. Existing MXC enforcement gaps and the separate executor's prerequisites remain as documented.
Testing
https-capassed with no E2E skips. Existing documented MXC enforcement gaps remain.28de5674: CLI ZIP 10,039,249 → 10,131,535 bytes (+0.92%); gateway bundle 44,568,145 → 44,541,442 bytes (−0.06%); combined +65,583 bytes (+0.12%). Total extracted payload, including the baseline Z3 DLL, decreased by 458,752 bytes (−0.34%).79cb5d67with no findings./windows-cipassed for79cb5d67: check, release build, all four PE/static CRT/Z3 audits, 6,663 tests passed / 43 existing skips / no flaky retries, unsupported-driver contracts and all four feature combinations, plus both ZIP extraction/startup smokes. Build and GitHub-report jobs succeeded. The runner ignored its inherited shared override and downloaded/cached the pinned static Z3 5.1.0 package; no Z3 source compilation.The earlier security-review retry returned “Codex review is not enabled for this repo”. No actionable security finding was returned.
Checklist