Skip to content

feat(providers): support basic client auth and resource in OAuth refresh - #5668

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:feat/5663-oauth-basic-resource/ericcurtin
Nov 18, 2026
Merged

johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:feat/5663-oauth-basic-resource/ericcurtin

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

OAuth refresh providers can now use client_secret_basic and send an RFC 8707 resource indicator.

Related Issue

Closes #5663

Changes

  • Add token_endpoint_auth_method and resource material keys.
  • Share one request builder between the refresh token and client credentials strategies.
  • Validate both keys when refresh is configured.
  • Document the keys.

Release Notes

Refresh providers accept token_endpoint_auth_method=client_secret_basic and resource=<uri>. Defaults are unchanged.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Minter, server and docs checks pass, and clippy is clean on the credential issuer.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

PTAL when you get a chance, and /ok to test 80fed52a5 if it looks good. Thank you!

@ericcurtin

Copy link
Copy Markdown
Contributor Author

Full SHA for the gate: /ok to test 80fed52a56de827e1326c99c797bb72606b7abf2

@johntmyers johntmyers added the test:e2e Requires end-to-end coverage label Nov 17, 2026
@johntmyers

Copy link
Copy Markdown
Collaborator

/ok to test 80fed52

@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/5668 does not exist yet. A maintainer needs to comment /ok to test 80fed52a56de827e1326c99c797bb72606b7abf2 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

PR Review Status

The independent review found no blocking issues in the OAuth request builder, configuration validation, dependency wiring, tests, or docs. @ericcurtin, I checked the full head SHA you supplied, applied test:e2e, and posted the full-SHA test command; the mirror now matches and required workflows have started.

Blocking findings:

  • No blocking findings remain.

Carried findings:

  • None.

Non-blocking suggestions:

  • None.
Gator metadata
  • Validation: Focused implementation of accepted issue Support OAuth client_secret_basic and resource indicators for refresh providers #5663.
  • Docs: Fern provider-profile docs describe both new material keys and authentication defaults.
  • Checks: Current-head Branch Checks and Helm Lint are running; Trivy Changes passed. DCO and vouch checks passed.
  • E2E: test:e2e applied. E2E Label Help requested a mirror; /ok to test created the current-head mirror and Branch E2E Checks run 44197920461 is running with suite build jobs queued. Outcomes pending.
  • Verification: Code-only independent review and diff whitespace check completed; no local Rust toolchain is installed, so tests are delegated to CI.
  • Head SHA: 80fed52a56de827e1326c99c797bb72606b7abf2
  • Base SHA: d66d33844373d66ec0ad0ca63e5cea5a6112ad75
  • Merge base SHA: d66d33844373d66ec0ad0ca63e5cea5a6112ad75
  • Patch ID: c1dfab6d17bd8f2b5264d9db5dd9e4d04e20c418
  • Gator payload: 13
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Next state: gator:watch-pipeline

@johntmyers johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status gator:blocked Gator is blocked by process or repository gates gator:approval-needed Gator completed review; maintainer approval needed and removed gator:watch-pipeline Gator is monitoring PR CI/CD status gator:blocked Gator is blocked by process or repository gates labels Nov 17, 2026
@johntmyers
johntmyers enabled auto-merge November 18, 2026 15:23
@johntmyers
johntmyers added this pull request to the merge queue Nov 18, 2026
@johntmyers johntmyers added gator:blocked Gator is blocked by process or repository gates and removed gator:approval-needed Gator completed review; maintainer approval needed labels Nov 18, 2026
Merged via the queue into NVIDIA:main with commit eabc6da Nov 18, 2026
286 of 293 checks passed
@johntmyers johntmyers removed the gator:blocked Gator is blocked by process or repository gates label Nov 18, 2026
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: The current head already received a Gator review with no blocking findings, and maintainer approval was present before merge.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OAuth client_secret_basic and resource indicators for refresh providers

2 participants