Repository navigation
Conversation
…supervisor Add gateway.listenAddress and supervisor.listenAddress, defaulting to 0.0.0.0. Setting :: renders bracketed addresses such as [::]:8080. Closes #5597 Signed-off-by: divesh <dgude@nvidia.com>
Collaborator
Author
|
/ok to test 3cbffbf |
|
🌿 Preview your docs: https://nvidia-preview-pr-5669.docs.buildwithfern.com/openshell |
Compatibility review (advisory)New or updated breaking changes; see the full report for all findings. 1. helm — No explicit risk acceptance foundHelm upgrades with --reuse-values previously needed no listener-address keys but now require gateway.listenAddress and, for shared supervisors, supervisor.listenAddress.
Review details
Advisory review; publication gates are unchanged. |
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
gateway.listenAddressandsupervisor.listenAddressso the gateway and shared supervisor can listen on IPv6. Both default to0.0.0.0.Related Issue
Closes #5597
Changes
gateway.listenAddressandsupervisor.listenAddress.::becomes[::]:8080.Release Notes
Set
gateway.listenAddressandsupervisor.listenAddressto::to run the gateway and shared supervisor on IPv6 clusters.Testing
mise run helm:test,mise run helm:lint, andmise run helm:docs:checkpassDeployed on a dual-stack, IPv6-primary kind cluster with both values set to
::: the gateway and shared supervisor became Ready, and sandbox create and exec succeeded.Checklist