Repository navigation
ci(setup-nix): disable HTTP/2 for Nix downloads - #5688
Merged
Merged
Conversation
A failed HTTP/2 connection fails every NAR multiplexed on it. Nix resumes NARs that had fully arrived at EOF, gets HTTP 416, and fails the substitution (NixOS/nix#16722). Separate HTTP/1.1 connections confine a failure to one transfer. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
matthewgrossman
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
November 18, 2026 04:24
TaylorMutch
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
http2 = falsefor the CI Nix daemon to reduce a recurring Nix download flake (HTTP error 416, thenno substituter that can build it).determinate-nix-action.Related Issue
No issue; this fixes a flaky CI failure. Example: job 134410447281 failed both of its
nix buildattempts this way.The failure sequence:
416 Range Not Satisfiable.Over the last 4 weeks, 53 job attempts hit this. In all 58 failed downloads, the resume offset equals the NAR size. The retry-once wrappers in setup-nix and e2e-suites absorbed all but one of those attempts, but the rate rose to 9–14 a day on 11-16 and 11-17.
Changes
extra-conf: http2 = falsetoDeterminateSystems/determinate-nix-actionin.github/actions/setup-nix/action.yml.Why this should help:
CURLE_SEND_ERROR("Failed sending data to the peer").Upstream
Nix needs to fix this. The fix is proposed but not merged or released:
Content-Range: bytes */Nmatches the bytes already received.Once a Determinate Nix release includes the fix, we can bump
determinate-nix-actionand decide whether to keep this setting.Testing
ubuntu-24.04jobs each fetched the fullopenshell-test-runnerclosure (581 paths, 2.7 GiB) into fresh stores, alternatinghttp2 = trueandfalse. That's 120 fetches per arm, with no failures in either arm.nix config showreportedhttp2 = false, and the HTTP/1.1 arm had no HTTP/2 framing errors.Checklist