Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
f1cd23a
test(conformance): port sandbox lifecycle and API e2e tests to testkit
matthewgrossman Nov 9, 2026
81965a0
test(testkit): add CLI sandbox, exec success, details, wait_absent an…
matthewgrossman Nov 9, 2026
97f2f24
test(conformance): use ExecOutput::success for exec checks
matthewgrossman Nov 9, 2026
2e5acae
test(testkit): add create_ready, expect_stdout, poll_exec and deadlin…
matthewgrossman Nov 10, 2026
d003256
test(server): drive the WebSocket tunnel test through the SDK tunnel …
matthewgrossman Nov 10, 2026
aa4b67d
test(gateway): build the preflight report once
matthewgrossman Nov 10, 2026
db71d84
refactor(testkit): make the sandbox and output helpers uniform
matthewgrossman Nov 10, 2026
a8765e1
refactor(testkit): reuse YamlFile and report stdout when CLI checks fail
matthewgrossman Nov 10, 2026
a96df3a
refactor(testkit): use the new sandbox helpers with the credential ga…
matthewgrossman Nov 10, 2026
84b2f06
test(gateway): compile the proxy preflight tests only with a proxy-ta…
matthewgrossman Nov 10, 2026
034814b
test(conformance): wait for labeled sandboxes and allow a 60s on-fail…
matthewgrossman Nov 10, 2026
1ed49ce
refactor(testkit): share sandbox handles and output checks across bui…
matthewgrossman Nov 10, 2026
163fa4d
refactor(testkit): tighten error helpers and document test scope
matthewgrossman Nov 10, 2026
370e441
test(e2e): keep edge tunnel and ephemeral cleanup e2e until their ports
matthewgrossman Nov 10, 2026
779561a
chore(tasks): drop the live-Internet perf benchmark port
matthewgrossman Nov 10, 2026
1cd665d
test(e2e): restore the docker proxy settings insertion unit test
matthewgrossman Nov 10, 2026
139dc5d
test(conformance): ignore the on-failure restart test until #5507
matthewgrossman Nov 12, 2026
b013446
test(e2e): keep the on-failure restart and global settings tests in e…
elezar Nov 12, 2026
4694bc0
test(conformance): only read the global setting in the settings round…
matthewgrossman Nov 12, 2026
b5f0737
docs(conformance): point the global settings test at #5527
matthewgrossman Nov 12, 2026
4244ffb
test(testkit): add CliChild for long-running CLI processes
matthewgrossman Nov 9, 2026
933f6ea
test(e2e): port CLI exec, attach, and SSH host identity tests to testkit
matthewgrossman Nov 10, 2026
40b8c5a
Merge remote-tracking branch 'origin/main' into test/5426-port-cli-at…
matthewgrossman Nov 16, 2026
eedd41f
fix(testkit): close stdin when killing a CliChild
matthewgrossman Nov 16, 2026
f394ed8
test(conformance): attach to attached-create mains before they exit
matthewgrossman Nov 16, 2026
a40f0cc
docs(conformance): link the gateway-restart host identity follow-up
matthewgrossman Nov 17, 2026
68160b0
test(conformance): cover attached create and --no-keep with a main te…
matthewgrossman Nov 17, 2026
f90a4cc
test(features): rename cli-attach to connect-ssh-supervision
matthewgrossman Nov 17, 2026
ef08457
test(testkit): add providers, run_python, last_json, policy readers a…
matthewgrossman Nov 18, 2026
e451141
test(host-server): add TEST_HOST
matthewgrossman Nov 18, 2026
8851241
test(support): add sandbox-clients crate with connect and http probes
matthewgrossman Nov 18, 2026
b7fcc98
test(features): use shared helpers in host-gateway
matthewgrossman Nov 18, 2026
f7c97f2
test(suites): drop ready_sandbox wrappers and unify long-running comm…
matthewgrossman Nov 18, 2026
70aaaf3
docs(testkit): list the shared sandbox helpers
matthewgrossman Nov 18, 2026
dcf9567
test(suites): use shared sandbox and provider helpers in cli, cdi and…
matthewgrossman Nov 18, 2026
70adbdc
test: trim unit tests for the shared sandbox helpers
matthewgrossman Nov 18, 2026
4fa87f9
test(features): leave the keycloak refresh test to #5657
matthewgrossman Nov 18, 2026
b76ff7b
test(testkit): fail early on sandbox names the gateway rejects
matthewgrossman Nov 18, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .config/nextest.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ failure-output = "immediate-final"
slow-timeout = { period = "30s", terminate-after = 4 }

[profile.e2e-kubernetes]
# Temporary waiver: port-forward reconnect can attach read-only while the old
# SSH session retains stdin ownership. Keep recovery coverage on other drivers.
# Remove this exclusion after resolving https://github.com/NVIDIA/OpenShell/issues/4445.
default-filter = "not test(/^canonical_main_connect_recovers_its_ssh_transport$/)"
fail-fast = false
status-level = "slow"
final-status-level = "fail"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/e2e-suites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ jobs:
{"environment":"fedora-podman-rootless","installer":"rpm","family":"features","package":"host-gateway","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"ubuntu-k3s","installer":"k3s","family":"features","package":"host-gateway","gateway":"tmachine","runner":"ubuntu-24.04"},
{"environment":"ubuntu-k3s","installer":"k3s-ha","family":"features","package":"host-gateway","gateway":"tmachine","runner":"ubuntu-24.04"},
{"environment":"ubuntu-docker-rootful","installer":"deb","family":"features","package":"connect-ssh-supervision","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootful-keycloak","installer":"rpm","family":"features","package":"keycloak-provider-refresh","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootless-keycloak","installer":"rpm","family":"features","package":"keycloak-provider-refresh","gateway":"openshell","runner":"ubuntu-24.04"},
{"environment":"fedora-podman-rootful-userns-default","installer":"rpm","family":"drivers/podman","gateway":"openshell","runner":"ubuntu-24.04"},
Expand Down
6 changes: 6 additions & 0 deletions TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,12 @@ rootful and rootless, and the `k3s` and `k3s-ha` installers. The tests run on
the K3s node, so the K3s installers set the chart's `server.hostGatewayIP` to
the node's address.

The `connect-ssh-supervision` feature suite
(`tests/suites/features/connect-ssh-supervision`) checks how `sandbox connect`
supervises its `ssh` process: it reconnects after losing the SSH transport and
forwards a SIGTERM to `ssh`. The tests find those processes in `/proc`, so they
need a Linux test host. CI runs them on Docker rootful.

Run the VM-backed Rust CLI e2e suite:

```shell
Expand Down
19 changes: 0 additions & 19 deletions e2e/rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion e2e/rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,6 @@ tonic-prost = "0.14"
tokio-rustls = { version = "0.26", default-features = false, features = ["logging", "tls12"] }
tower = "0.5"
url = "2"
nix = { version = "0.29", features = ["process", "signal", "term", "user"] }

[dev-dependencies]
flate2 = "1"
Expand Down
35 changes: 0 additions & 35 deletions e2e/rust/src/harness/binary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,41 +52,6 @@ pub fn openshell_cmd() -> tokio::process::Command {
cmd
}

fn shell_escape(arg: &str) -> String {
if arg
.chars()
.all(|c| c.is_ascii_alphanumeric() || "-_./:@".contains(c))
{
return arg.to_string();
}

format!("'{}'", arg.replace('\'', "'\\''"))
}

/// Create a [`tokio::process::Command`] that runs `openshell` under a PTY.
pub fn openshell_tty_cmd(args: &[&str]) -> tokio::process::Command {
let bin = openshell_bin();
let mut cmd = tokio::process::Command::new("script");

if cfg!(target_os = "macos") {
cmd.arg("-q").arg("/dev/null").arg(bin).args(args);
} else {
let mut shell_command = shell_escape(bin.to_str().expect("openshell path is utf-8"));
for arg in args {
shell_command.push(' ');
shell_command.push_str(&shell_escape(arg));
}
cmd.arg("-q")
.arg("-e")
.arg("-c")
.arg(shell_command)
.arg("/dev/null");
}

cmd.kill_on_drop(true);
cmd
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
4 changes: 2 additions & 2 deletions e2e/rust/tests/oidc_pkce.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1457,8 +1457,8 @@ async fn delete_workspace(admin: &LoginSession, workspace: &str) {
}

// Keep RBAC fixtures running until cleanup so authorization checks do not also
// exercise fast canonical-process completion. That lifecycle belongs to the
// dedicated sandbox_lifecycle suite.
// exercise fast canonical-process completion. The conformance `lifecycle`
// suite covers that.
async fn assert_can_create_sandbox(session: &LoginSession, workspace: &str, sandbox_name: &str) {
let create = run_workspace_cli(
session,
Expand Down
Loading
Loading