Skip to content

fix(helm): normalize app version labels - #5694

Merged
TaylorMutch merged 1 commit into
mainfrom
fix/5692-helm-version-labels/TaylorMutch
Nov 18, 2026
Merged

TaylorMutch merged 1 commit into
mainfrom
fix/5692-helm-version-labels/TaylorMutch

Conversation

@TaylorMutch

Copy link
Copy Markdown
Collaborator

Summary

Normalize the Helm chart's app.kubernetes.io/version label so SemVer build metadata cannot block gateway installs or upgrades. For example, 0.1.9+build.1 renders as 0.1.9_build.1 in labels while chart metadata and image selection retain their original values.

Related Issue

Closes #5692

Changes

  • Replace + with _ in the common version label, cap it at 63 characters, and trim boundary punctuation after truncation.
  • Add 12 Helm regression cases covering workloads, Services, certgen hooks, normal/prerelease versions, truncation boundaries, and image tag/digest behavior.
  • Update deployment troubleshooting guidance for invalid version labels.

Release Notes

Testing

  • Checks appropriate to the affected code and behavior pass: mise run helm:lint, mise run helm:test (484 gateway and 7 workspace unit tests plus chart ownership, Rust configuration-loader, resource-coherence, and supervisor-scaling checks), Markdown lint, and git diff --check.
  • Unit tests added/updated: all 12 new cases pass with the fix; six fail against the original chart.
  • E2E verification performed: on local k3d/Kubernetes v1.31.5 with Helm v4.2.0 and the same digest-pinned, locally built gateway image, installed a baseline release, reproduced the original chart's pre-upgrade certgen ServiceAccount rejection for 0.1.9+build.1, then upgraded that failed release with the fixed chart. Certgen completed, Helm recorded revision 3 as deployed, and the gateway became Ready with version label 0.1.9_build.1. The isolated release and namespace were removed afterward.
  • Packaged-chart comparison: 19 invalid version labels before, zero after, with explicit tags and digests; image references and rendered gateway.toml are unchanged and archived Chart.yaml retains 0.1.9+build.1. An empty appVersion still omits the label. No full sandbox E2E suite was run for this label-only change.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 18, 2026
@TaylorMutch TaylorMutch added area:platform SDKs, CLIs, APIs, gateway infrastructure, persistence, configuration, and session management. topic:kubernetes Kubernetes operators, CRDs, deployment controllers, and native Kubernetes API integration. topic:operability Installing/configuring deployments, upgrades, backup/restore, diagnostics, and maintenance. labels Nov 18, 2026
@TaylorMutch
TaylorMutch marked this pull request as ready for review November 18, 2026 06:34
@TaylorMutch
TaylorMutch added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit f882962 Nov 18, 2026
102 of 106 checks passed
@TaylorMutch
TaylorMutch deleted the fix/5692-helm-version-labels/TaylorMutch branch November 18, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:platform SDKs, CLIs, APIs, gateway infrastructure, persistence, configuration, and session management. state:accepted A maintainer decided OpenShell should pursue this issue topic:kubernetes Kubernetes operators, CRDs, deployment controllers, and native Kubernetes API integration. topic:operability Installing/configuring deployments, upgrades, backup/restore, diagnostics, and maintenance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(helm): appVersion build metadata produces invalid Kubernetes labels

2 participants