Repository navigation
fix(helm): normalize app version labels - #5694
Merged
Merged
Conversation
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
TaylorMutch
marked this pull request as ready for review
November 18, 2026 06:34
drew
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize the Helm chart's
app.kubernetes.io/versionlabel so SemVer build metadata cannot block gateway installs or upgrades. For example,0.1.9+build.1renders as0.1.9_build.1in labels while chart metadata and image selection retain their original values.Related Issue
Closes #5692
Changes
+with_in the common version label, cap it at 63 characters, and trim boundary punctuation after truncation.Release Notes
Testing
mise run helm:lint,mise run helm:test(484 gateway and 7 workspace unit tests plus chart ownership, Rust configuration-loader, resource-coherence, and supervisor-scaling checks), Markdown lint, andgit diff --check.0.1.9+build.1, then upgraded that failed release with the fixed chart. Certgen completed, Helm recorded revision 3 as deployed, and the gateway became Ready with version label0.1.9_build.1. The isolated release and namespace were removed afterward.gateway.tomlare unchanged and archivedChart.yamlretains0.1.9+build.1. An empty appVersion still omits the label. No full sandbox E2E suite was run for this label-only change.Checklist