Repository navigation
test(e2e): port Docker and Podman driver feature tests from e2e/rust - #5695
Draft
matthewgrossman wants to merge 10 commits into
Draft
matthewgrossman wants to merge 10 commits into
matthewgrossman wants to merge 10 commits into
Conversation
…container-engine Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…leanup Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
… and ephemeral cleanup Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…ker and Podman Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…onfig on Docker and Podman Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…matthewgrossman' into test/5676-port-docker-podman-features/matthewgrossman Signed-off-by: Matthew Grossman <mgrossman@nvidia.com> # Conflicts: # tests/testkit/README.md # tests/testkit/testkit/src/policy.rs
… host-gateway The EOF check runs its three responses in one sandbox and reads the close through the shared http_raw client. The stop/start check is the restart half of podman_host_gateway, which stays in e2e/rust until its DNS relay check is decided. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…ocsf Merges the class, attribution and schema checks of ocsf_jsonl_conformance into the stderr test. The sandbox denies a TCP connect and an L7 POST to an in-process host server, and the exec sessions add SSH Activity. ocsf_jsonl_conformance stays in e2e/rust for its /var/log file-sink check until that drop is decided. Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the
e2e/rusttests that need a container engine to testkit suites, so they run on the Docker and Podman rows instead of being gated to one engine. Draft: transparent TCP is not ported yet, and some legacy files stay until the drops in #5297 are decided.Related Issue
Closes #5676
Part of #5281
Stacked on #5665 (base
test/5655-port-network-l7-policy/matthewgrossman), which is stacked on #5691 and #5442. In-sandbox clients use only #5691's shared API (sandbox_clients_support,TEST_HOST,Sandbox::run_python). This branch merges #5691, so the diff shows its changes until #5665 merges it too.Changes
tests/suites/drivers/{docker,podman}: stop is terminal and ephemeral cleanup leaves no containers, one test per driver. Podman also checks the supervisor JWTexp.drivers/dockeris a new suite with its CI rows.features/resource-limits: checks that gateway info reports CPU and memorylimit_supported, then readscpu.maxandmemory.max.features/ocsf: supervisor stderr OCSF JSON records. Covers opt-in, clean stdout, gateway logs keeping only the shorthand, Network/HTTP/SSH Activity classes (denied connect, L7-denied POST to an in-process host server, exec sessions), container and image attribution, version, and OCSF schema validation.features/driver-config: existing volume, OCI workspace with a nested volume, and bind mount, on a new<base>-driver-configtmachine environment.features/host-gateway:response_eof.rsruns the three closing responses in one sandbox and checks the read ends withReadEnd::Closed.host_server_reachable_after_stop_startchecks the host server again after stop and start.Context::gateway_info.driver_config_volume.rs,ocsf_console.rsandpodman_resource_limits.rs, and the EOF test fromhost_gateway_alias.rs, plus the now-unusedbollarddependency.local_driver_token_restart.rsstays for now (see below).Defaults applied
allow_driver_config = trueandenable_bind_mounts = true, and disables resource admission, which blocks bind mounts. Test volumes still carry theopenshell.ai/sandbox-attachableand workspace labels.testkit::python_image(), because the default image has nosandboxuser. The bind source is a temp directory under$HOME.features/resource-limitshas no k3s row yet. The VM driver reportslimit_supported=false, so no VM issue was filed.Coverage that is new on a driver
Still to do
features/transparent-tcp:local_container_native_tcp_uses_policy_dns_and_fails_closedandrootless_podman_private_dns_pins_do_not_cross_binary_rules. These need shared clients that reportgetaddrinforesults and run a probe under a copied interpreter. They also need a decision on keeping a Podman fixture on the gateway network.local_driver_token_restart.rs: delete now, or keep its VM part until PR6.Pending drops (Decision D in #5297)
These stay in
e2e/rustuntil approved:ocsf_jsonl_conformance.rs, for its/var/logfile-sink check. Its other checks now live infeatures/ocsf.host_gateway_alias::sandbox_reaches_host_openshell_internal_via_host_gateway_alias.podman_host_gateway.rs, for its reachability half and thenameserver 127.0.0.53check. Its stop/start half now lives infeatures/host-gateway.transparent_tcp::rootless_podman_musl_getaddrinfo_uses_udp_policy_dns.Testing
cargo fmt --checkon testkit, support, drivers/docker, drivers/podman, features, conformance ande2e/rust.cargo clippy --locked --all-targets -- -D warningson the same workspaces.Unit tests in
tests/supportand thefeatures/ocsfrecord parser.uv run tasks/scripts/check_cargo_lockfile_alignment.py.Not run end to end locally: on macOS the supervisor can't reach a gateway bound to 127.0.0.1. These rely on the CI tmachine rows.
Podman rows may flake on
ContainerExiteduntil fix(server): skip the reconcile poll of a sandbox whose start is in progress #5265 merges.Checks appropriate to the affected code and behavior pass
Unit tests added/updated (if applicable)
E2E tests added/updated (if applicable)
Checklist