Skip to content

fix(network): bracket IPv6 literals in the transparent CONNECT authority - #5696

Open
FrostGod wants to merge 1 commit into
mainfrom
fix/5693-transparent-ipv6-literal/FrostGod
Open

FrostGod wants to merge 1 commit into
mainfrom
fix/5693-transparent-ipv6-literal/FrostGod

Conversation

@FrostGod

@FrostGod FrostGod commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Transparent egress to an allowed IPv6 address was closed with no response. The internal CONNECT authority was built as fd00::5:8081, which parse_target rejects; it is now [fd00::5]:8081.

Related Issue

Closes #5693

Changes

  • Build the transparent CONNECT authority with SocketAddr for IP hosts, so IPv6 is bracketed. Hostnames and IPv4 are unchanged.

Testing

  • cargo test -p openshell-supervisor-network --lib -- transparent_connect_authority parse_target, cargo fmt, and cargo clippy -p openshell-supervisor-network --all-targets -- -D warnings pass
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

On an IPv6-only kind cluster, a sandbox request to an IPv6 Service IP allowed by allowed_ips now succeeds; on main it was closed with no response.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Transparent egress to an IPv6 destination built an unbracketed
authority that parse_target rejects, so the connection was closed.

Closes #5693

Signed-off-by: divesh <dgude@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the state:accepted A maintainer decided OpenShell should pursue this issue label Nov 18, 2026
@FrostGod

Copy link
Copy Markdown
Collaborator Author

/ok to test 8cec7fe

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:accepted A maintainer decided OpenShell should pursue this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(network): transparent egress to an IPv6 literal fails

1 participant