Conversation
Expose Qwen generation through the semantic TextContinuation contract while retaining the existing graph, sampler, native-KV and distributed paths. Move family support and qualification manifests to the new task, and add config and SDK consumer coverage. Rebuilt bundles are required for the new primary task.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
I, JiaxinD <djx2048@gmail.com>, hereby add my Signed-off-by to this commit: 130e2cc Cover the semantic primary Task across all declared Qwen model types. Signed-off-by: JiaxinD <djx2048@gmail.com>
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Qwen advertises the legacy
text_generationmode and cannot be accessed through the semanticTextContinuationSDK. This implements #1498.Exit Criteria
text_continuation, with UTF-8 and token-ID inputs.Implementation
ITextContinuationwith family-owned Config parsing and vocabulary validation.families/qwen.Change categories
Validation
Commands and Results
cmake --build build-sm90 --parallel 8 --target trtmc trtmc_backend_trt trtmc_model_qwen test_qwen_task_config test_qwen_sampler test_qwen_tensor_names test_qwen_native_kv_cachectest --test-dir build-sm90 --output-on-failure -R '^(qwen_task_config|test_qwen_sampler|test_qwen_tensor_names|test_qwen_native_kv_cache)$'python -m pytest families/qwen/tests/test_support.py families/qwen/tests/test_builder_policy.py families/qwen/tests/test_runtime_receipt.py families/qwen/tests/test_checkpoint_shape_contract.py -qpython -m pytest 'families/qwen/tests/test_e2e.py::test_e2e[qwen3-0.6b-native-l0]' 'families/qwen/tests/test_e2e.py::test_e2e[qwen3-0.6b-fp16]' 'families/qwen/tests/test_e2e.py::test_e2e[qwen3-0.6b-fp16-native-kv-two-chunk-parity]' 'families/qwen/tests/test_e2e.py::test_e2e[qwen3-0.6b-topp]' -vv -s --basetemp=/work/e2e-temp --junitxml=/work/evidence/e2e.xmlEarlier registry/impact checks, Ruff and SDK syntax checks passed; current worktree and
git diff --checkare clean. Current-head Stable/Dev Community CI pass; this is separate from the local GPU evidence.Hardware, Environment, and Revisions
Head
9aa55f6ee9ccc7fde6715dd37e5c86a466431552, base79f229243d517bf51db69f50b21c25d2d7e4b6fe.Qwen/Qwen3-0.6Brevisionc1899de289a04d12100db370d81485cdf75e47ca, cached offline. One H200, SM90, driver 595.71.05, Ubuntu 24.04, CUDA 13.3, TensorRT 11.1.0.106, PyTorch 2.12.0+cu130, Transformers 5.2.0. Imagenvcr.io/nvidia/tensorrt:26.07-py3@sha256:b82db1abc23750ab0069abc99bbe4ea29138dbdc23ea39861199e2346638b48a.E2E used
TRTMC_E2E=1,TRTMC_BINARY=/work/source/build-sm90/trtmc,TRTMC_RUNTIME_ROOT=/work/source/build-sm90,TRTMC_NATIVE_BUILD_DIR=/work/source/build-sm90,CUDA_VISIBLE_DEVICES=0andHF_HUB_OFFLINE=1. JUnit, checkpoint revision, binary hashes and family evidence were retained.Not Run / Remaining Gaps
FP8, TP4, Qwen3-4B and the long-context regression were not run in this single-device validation. No throughput, latency or memory-equivalence claim. Protected Internal CI has not reported a premerge result for this PR.
Contributor Self-Review
Notes For Future Readers
Token-ID input bypasses chat templating and re-tokenization. Review Config, pipeline binding and consumers in that order. Rebuild bundles before use. Scoped native validation is complete; repository review capacity and protected CI remain separate requirements.
Risk level
The primary task changes SDK dispatch and requires rebuilding existing Qwen bundles.