Repository navigation
Conversation
Signed-off-by: Layali Rashid <lrashid@nvidia.com>
Signed-off-by: Layali Rashid <lrashid@nvidia.com>
layalir
marked this pull request as ready for review
September 29, 2026 12:19
Contributor
[Medium impact] No actionable defect was established; the PR appears safe to merge. SummaryAdds opt-in compact GQA backward for supported SM107 BF16 packed attention.
No new actionable issues were established. Tests were inspected but not run during this review. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Fused attention backward] --> B{Compact path enabled and supported?}
B -->|No| S[Stock backward]
B -->|Yes| C{Packing metadata registered and current?}
C -->|No| S
C -->|Yes| D[Get cached plan and scoped scratch]
D --> E[Run compact backward]
E --> F[Return gradients]
Reviews (4) · Last reviewed commit: "Merge branch 'main' into gqa-native-inte..." · Reviewed by Greptile |
Signed-off-by: Layali Rashid <lrashid@nvidia.com>
Signed-off-by: Layali Rashid <lrashid@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in compact GQA backward through cuDNN Frontend. Register host packing offsets and scope scratch reuse to forward/backward; unsupported inputs keep the existing path.
Enable with
NVTE_CUDNN_COMPACT_GQA_BWD=1. Supports SM107, BF16 packed THD, Hq=8/Hkv=1, D=256, and causal attention.Validation: 39 CPU contract tests across the companion changes and three native SM107 numerical cases passed. Latest full-workload A/B reduced mean policy-training time by 1.46%; rollout token counts differed, so timings are not normalized. The complete required L0 suites remain pending.
Requires NVIDIA/cudnn-frontend#1207. Packing integration: NVIDIA-NeMo/RL#4293.