Repository navigation
[JAX] Synchronize tutorial speedometer measurements - #3830
KshitijLakhani wants to merge 3 commits into
Conversation
Wait for the complete forward/backward result tree after warmup and before stopping the timer so the reported batch average covers completed device work rather than asynchronous dispatch. Signed-off-by: Kshitij Janardan Lakhani <klakhani@nvidia.com>
Use time.perf_counter() consistently in the shared tutorial speedometer and both context-parallel attention timing loops to measure elapsed durations with a monotonic clock. Signed-off-by: Kshitij Janardan Lakhani <klakhani@nvidia.com>
6b86b06 to
2780139
Compare
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates JAX tutorial benchmarks to wait for results before starting and stopping measurements.
Reviews (2) · Last reviewed commit: "Refresh JAX tutorial performance results..." · Reviewed by Greptile |
|
@jberchtold-nvidia if this change makes sense to you (for sync'ing the work after warm up and after completing the actual work) then I can re-run the numbers on GB200 and add them to this PR (if there's any changes) |
|
/te-ci jax L0 |
Signed-off-by: Kshitij Janardan Lakhani <klakhani@nvidia.com>
|
@jberchtold-nvidia I reran the JAX tutorial benchmarks on GB200 after fixing synchronization in the timer, then refreshed the checked-in attention, dense, and context-parallel results. If you are curious about the change in timings, here's more info:
|
Description
Fix JAX tutorial benchmark timing so reported durations include completed forward and backward computation.
Type of change
Changes
time.perf_counter()consistently across JAX tutorial timing loops.Checklist: