Repository navigation
Support USD cone and focus shaping on quad lights - #376
Merged
Merged
Conversation
kvankooten
force-pushed
the
quad-light-shaping
branch
from
October 20, 2026 10:47
5b8d123 to
3b359de
Compare
tarcila
approved these changes
Oct 20, 2026
tarcila
left a comment
tarcila
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. One small thing that I'll address later on: the light picker ignores cone and focus. Still unbiased, but slower to converge when the feature is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quad lights currently emit without angular cone or focus controls. Add
ANARI_VISRTX_LIGHT_QUAD_SHAPINGandANARI_VISRTX_LIGHT_QUAD_FOCUSto expose USD-style cone angle/softness and focus/tint parameters.Illumination and visible/reflected light proxies use the same radiance attenuation. Unset parameters preserve the existing behavior, and uniform-area sampling and its probability density remain unchanged.
This branch contains one feature commit directly on
next_release, with no MDL or texture dependency.Validation after rebasing onto
next_release(73c02f6a, 2026-10-20): Windows Release rebuild with CUDA 13.2 and OptiX 7.7, with MDL disabled. TestQuadLightShaping, TestQuadLightFocus, 6 host unit tests and 4 existing lighting regressions all passed.The combined rendering-integration branch starts from the merged upstream MDL implementation and adds both lighting branches. All 21 feature, host and rendering checks passed, including the upstream MDL descriptor/binding tests and shaping-plus-texture composition.