Repository navigation
fix(rtx): select fog origins by value and simplify fog test matrices - #383
Merged
jeffamstutz merged 5 commits intoOct 28, 2026
Merged
Conversation
Black planes and implicit instances cannot witness lost albedo or application instance IDs when expensive fog matrices are reduced. Task: rtx-test-simplification Ticket: 05-cheap-fog-semantics-anchors
Keep independent coverage anchors expensive while avoiding identical endpoint and opaque-rear products. Paired edge and recommit oracles need fewer samples without weaker tolerances; public sample counts keep automatic restart non-vacuous. Task: rtx-test-simplification Ticket: 06-simplify-fog-coverage-tests
Separate selector products from transport variations while retaining independent radiance and coverage anchors. Pair lower-budget fog comparisons with matching fresh baselines. Task: rtx-test-simplification Ticket: 07-simplify-fog-transport-tests
Separate selector coverage from contribution paths so redundant products do not dominate feedback. Preserve stochastic budgets where camera coverage or Beer survival does not cancel. Task: rtx-test-simplification Ticket: 09-simplify-fog-interaction-tests
jeffamstutz
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix fog regression since (unrelated) 0e79325, working around what looks like a broken compiler codegen the aforementioned commit revealed.
Also augment the fog test coverage.