Repository navigation
Conversation
…n tests Two test cases passed RunsOn a hard-coded compute capability (8.0 or 9.0, and 7.5 and 9.0). dispatch_to_cc_list asserts that the capability is one the binary was compiled for, so both test cases aborted in single-architecture builds such as CMAKE_CUDA_ARCHITECTURES=86. Take the capabilities from cuda::__target_compute_capabilities() instead, and skip the mismatch case when the build has only one.
Contributor
This was referenced Oct 22, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #12154
Two test cases in
cub/test/catch2_test_device_radix_sort_runs_on.cu(added in #10998) passedRunsOna hard-coded compute capability:dispatch_to_cc_listasserts that the capability is one ofcuda::__target_compute_capabilities(). So in a single-architecture build both test cases abort. The[CTK13.4 GCC16 C++23] HostLaunch(amd64, RTXA6000): sm{86}job fails this way on unrelated PRs, for example #12131 and #12138.This PR takes the capabilities from
cuda::__target_compute_capabilities():SKIP()is not available yet, same pattern ascatch2_test_device_radix_sort_keys.cu).all-major-cccllist (75, 80, 90, 100, 120) this still covers 7.5 and 9.0.Testing
cub.test.device.radix_sort_runs_on.lid_0,cub-lid0preset, nvcc 13.4.59, gcc 16.2.1, C++17, RTX 5070 Ti (sm_120):CMAKE_CUDA_ARCHITECTURES86dispatch_to_cc_listassertion75;90;12086;120I could not build the C++23 configuration locally: nvcc 13.4.59 rejects gcc 16.2's
<string>in C++23 mode. The change does not depend on the dialect.Checklist