fix: Clarify the graphics and display driver capabilities - #477
Open
ehfd wants to merge 1 commit into
Open
Conversation
Signed-off-by: Seungmin Kim <8457324+ehfd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer: @cdesiniotis @henry118
Please feel free to edit my branch as required.
Summary
The driver capability table describes
graphicsas "Required for running OpenGL, EGL, and Vulkan applications" anddisplayas "required for leveraging X11 display." A user with a Vulkan or OpenGL application that displays its output follows that tographicsalone and ends up with a driver that cannot present.Changes
graphics— required for rendering OpenGL, EGL, and Vulkan applications.display— required for displaying X11 or Wayland windows; impliesgraphics.NVIDIA_DRIVER_CAPABILITIESreplaces the default capabilities rather than adding to them, withcompute,graphics,displayas the example.computeandgraphicsbegan their descriptions with a capitalRequiredwhile the other four rows did not; all six now match.Why
Measured on NVIDIA Container Toolkit and libnvidia-container 1.20.0, driver 580.178.04, 2x Tesla P100, against an NVIDIA-driven X server, with the capability string as the only variable between runs:
Two things follow that the page does not say today:
graphicsis not sufficient for an application that displays its output.displaysupplies/dev/nvidia-modeset, which the NVIDIA client driver needs for its window-system integration. This is not X11-specific — the same applies to Wayland and to off-screen surfaces where no X server is involved, so describingdisplayas being for X11 is incomplete.Because the variable replaces the default set rather than extending it,
graphics,displayon its own silently dropscomputeand the application fails to start at all. The value that works iscompute,graphics,display.Related
/dev/nvidia-modesetinstead of assuming it exists libnvidia-container#388 — discussion of thegraphics/displayboundary that this wording settles on the documentation side.