Repository navigation
Docs: uncertainty quantification guide for transient-chain error bars - #143
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
tpn
marked this pull request as ready for review
October 29, 2026 21:13
tpn
approved these changes
Oct 29, 2026
tpn
force-pushed
the
codex/transient-single-source
branch
from
October 29, 2026 22:51
f7bb0fd to
7212a2d
Compare
Signed-off-by: Carmelo Gonzales <43048528+melo-gonzo@users.noreply.github.com>
…ntification guide Signed-off-by: Carmelo Gonzales <43048528+melo-gonzo@users.noreply.github.com>
Scale derivative weights by the fitted lobe flux and use the position fit error when combining the uncertainty terms. Signed-off-by: Trent Nelson <trentn@nvidia.com>
tpn
force-pushed
the
codex/transient-uq-guide
branch
from
October 29, 2026 23:13
0c56ae6 to
211b10e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base: the single-source PR #141. Merge after it. Documentation only.
Summary
Adds
docs/uncertainty-quantification.md, a guide to the error bars the transient-chain example writes for the dipole center, the source position and the PSF flux. The guide covers:<q>_err, and a three-step workflow (run, read, check)launch.py, reading<q>_errand its terms from the catalog, andrepeat_catalogs.pycuphoton.xfit,cuphoton.xpoisorcuphoton.xrepfunction that computes it, with links to the component pagesuqconfiguration block, what each term needs from the survey and the earlier stages, and theuq.excludedreasonsgenericandrubinadapterssummary.jsonfields that record how the error bars were builtcompare_catalogs.pyreports, and coverage on injected sourcesdocs/README.mdlinks the guide under "Adapting and validating".docs/glossary.mdgains Correlation factor, Coverage, Error bar, Error budget, Kernel mismatch and Repeat test.The guide describes the code in this stack. The kernel-mismatch position step and the residual-background term are not in it yet, so the guide lists positions without a kernel-mismatch term as a limit.
Validation
summary.jsonkeys and exclusion reasons were checked against the code. A second read-only review against the code found seven inaccuracies, all fixed in this commit.pre-commit run --fileson the three files: every hook that applies to Markdown passed. The mypy hook did not run because the lockfile supports Linux only and the run was on macOS. No Python changed.Repository hygiene
Stack
mainmainMerge each line bottom up.