Repository navigation
Conversation
contains() piped printf into `grep -qx` under `set -euo pipefail`. grep -q exits at the first match, printf can then die of SIGPIPE, and pipefail turns the match into a miss. On an aarch64 (GH200) host the guard failed 13 times in 50 with "error_enum_shared_pointer_layout is not in ERROR_EXAMPLES in smoketest.sh", a name that is in the array; on x86 it did not reproduce. Compare in a bash loop instead. 50 runs on the same host: 0 failures; a name really missing from ERROR_EXAMPLES is still reported. Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-error-example-status.shruns underset -euo pipefail, and itscontains()pipedprintfintogrep -qx.grep -qexits at the first match.printfcan then die of SIGPIPE, and pipefail turns the match into a miss.On a GH200 (aarch64) host,
just check-guardsfailed intermittently with:That name is in the array. The name sits early in the list, so grep exits while printf still has lines to write.
This PR compares in a bash loop instead.
Changes
cuda-oxide/scripts/check-error-example-status.sh:contains()compares in a bash loop instead of pipingprintfintogrep -qx.Testing
Removing
error_enum_shared_pointer_layoutfromERROR_EXAMPLESstill makes the fixed guard fail with that message.check-oxide-artifacts-parity.sh:55has the samegrep … | grep -qshape under pipefail, but its producer writes at most four lines, and I did not see it fail.just -f cuda-oxide/Justfile checkpasses -- fmt-check, clippy and check-intrinsics pass on GH200; the test stage did not fit on that host's disk, and this change touches only the guard script, run directly abovecargo oxide run <example>-- not applicableChecklist
git commit -s)