Repository navigation
Conversation
run_benches takes cargo flags (--features X) and ignores bare words, so the plain "smoke-test" argument from test_benchmarks.sh was dropped: every benchmark ran with full criterion measurement, and saved results to the criterion baselines the smoke mode is meant to leave alone. Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
This was referenced Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/test_benchmarks.shcallsSince
run_bencheswas changed to parse cargo flags, it takes--features Xand drops every bare word. Sosmoke-testnever reaches Cargo.run_all.shand the README's "fast, discards results" smoke test then run every benchmark with full criterion settings. They also savebasebaselines, which the smoke mode is meant to leave alone. The script's output is discarded, so nothing shows this.Changes
test_benchmarks.sh: pass--features smoke-test.Testing
B300, softmax bench, run the way
run_benchesruns it:With the fix,
test_benchmarks.shreports 4 passed / 4 failed on B300. The four failures (fmha,fmha_causal,gemm,launch_overhead) are unrelated to this change: on my host they come from a tileiras/toolkit version mismatch, which I am checking separately.just check-- not run; script-only changeChecklist
git commit -s)