Repository navigation
Conversation
Signed-off-by: Raul Estrada <raulestradaa@gmail.com>
This was referenced Oct 25, 2026
uurl
marked this pull request as ready for review
October 26, 2026 06:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing f32/f64 libdevice mappings for
tgamma,ilogbandldexp, includingscalbnaliases and standard-librarygamma()shims. This covers the scalar additions in the first stage of #1224 and verifies both integer-result and integer-argument signatures before the table-generation work.Refs #1224.
Changes
scalbn/scalbnfto the correspondingldexplibdevice functions.std::sys::cmath::tgamma{f}shims through the collector.ilogbreturnsi32, andldexptakes ani32exponent.math_special, checking libm and standard-library gamma, integer logarithms, scaling and a user-function control across both precisions.frexpand the generated math tables will follow in separate PRs.Testing
Validated on
sm_120awith the pinned Rust 1.99.1 toolchain.just checkpasses fromcuda-oxide/.math_specialpasses with--all-targets -- -D warnings.cargo oxide run math_specialpasses.libm_mathandmath_hyperbolicpass.Checklist
git commit -s)just -f cuda-oxide/Justfile checkpasses (the local mirror of CI: fmt, clippy, tests, guards, docs)cargo oxide run <example>passes, orcuda-oxide/scripts/smoketest.sh -o '^<example>$'