Repository navigation
feat(cargo-oxide): opt-in CUDA_OXIDE_LINKER=wild host linker - #1641
Open
deepakshirkem wants to merge 3 commits into
Open
deepakshirkem wants to merge 3 commits into
deepakshirkem wants to merge 3 commits into
Conversation
Setting CUDA_OXIDE_LINKER=wild links host binaries with wild (via clang --ld-path). Unset, empty, or 'default' keeps rustc's default linker. An unsupported value or a missing wild binary fails with a clear error. cargo oxide doctor reports wild as an optional tool and fails if it is requested but not installed. Signed-off-by: deepakshirkem <deepakshirke509@gmail.com>
Split the env/exit handling from the flag decision (host_linker_rustflags_for) so it can be tested with an injected value and wild lookup, following the find_cuda_toolkit_executable_with_env pattern. Tests cover unset/default, wild (trimmed), wild missing, an unsupported value, and that the linker flags come after user RUSTFLAGS so they take precedence. Signed-off-by: deepakshirkem <deepakshirke509@gmail.com>
Signed-off-by: deepakshirkem <deepakshirke509@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CUDA_OXIDE_LINKER=wildto link host binaries with wild, plus acargo oxide doctorcheck, unit tests and README docs. Off by default.