chore(core): cover viewport minimum zoom branches - #370
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Covers behavior-pan attribute removal and the minimum-scale zoom-out path, raising viewport.ts line coverage to 100% and branch coverage to 90%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com>
coryrylan
force-pushed
the
topic/upkeep/coverage/viewport-minimum-zoom
branch
from
October 3, 2026 13:18
e9731dd to
6fe31be
Compare
coryrylan
marked this pull request as ready for review
October 3, 2026 13:18
coryrylan
enabled auto-merge (rebase)
October 3, 2026 13:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage task selected because: “1 uncovered lines, 99.54% lines and 89.28% branches, the smallest gap below the 90% threshold.”
Measurement
viewport.tsline coverage: 99.54% → 100%viewport.tsbranch coverage: 89.28% → 90%No public API changed. This change only adds unit coverage for removing the
behavior-panattribute and requesting zoom-out at the minimum scale; adjacent uncovered branches were deliberately left alone.