Skip to content

chore(core): cover viewport minimum zoom branches - #370

Open
cursor[bot] wants to merge 1 commit into
mainfrom
topic/upkeep/coverage/viewport-minimum-zoom
Open

cursor[bot] wants to merge 1 commit into
mainfrom
topic/upkeep/coverage/viewport-minimum-zoom

Conversation

@cursor

@cursor cursor Bot commented Oct 3, 2026

Copy link
Copy Markdown

Selected task

Coverage task selected because: “1 uncovered lines, 99.54% lines and 89.28% branches, the smallest gap below the 90% threshold.”

Measurement

  • viewport.ts line coverage: 99.54% → 100%
  • viewport.ts branch coverage: 89.28% → 90%
  • Full local CI and all applicable core checks pass.

No public API changed. This change only adds unit coverage for removing the behavior-pan attribute and requesting zoom-out at the minimum scale; adjacent uncovered branches were deliberately left alone.

Open in Web View Automation 

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/elements/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1037cef5-c1ac-44a3-afb8-77852fbf02e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coryrylan coryrylan added the upkeep label Oct 3, 2026 — with Cursor
@github-code-quality

github-code-quality Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/vitest

The overall line coverage in commit 6fe31be in the topic/upkeep/coverag... branch remains at 99%, unchanged from commit 9f70897 in the main branch.


Updated October 03, 2026 13:29 UTC

Covers behavior-pan attribute removal and the minimum-scale zoom-out path, raising viewport.ts line coverage to 100% and branch coverage to 90%. No behavior change.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Cory Rylan  <coryrylan@users.noreply.github.com>
@coryrylan
coryrylan force-pushed the topic/upkeep/coverage/viewport-minimum-zoom branch from e9731dd to 6fe31be Compare October 3, 2026 13:18
@coryrylan
coryrylan marked this pull request as ready for review October 3, 2026 13:18
@coryrylan
coryrylan enabled auto-merge (rebase) October 3, 2026 13:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants