Skip to content

Ensure backport commits have verified signatures. - #2012

Merged
henry118 merged 1 commit into
NVIDIA:mainfrom
henry118:fix-cherrypick-bot
Aug 19, 2026
Merged

Ensure backport commits have verified signatures.#2012
henry118 merged 1 commit into
NVIDIA:mainfrom
henry118:fix-cherrypick-bot

Conversation

@henry118

Copy link
Copy Markdown
Member

Branch protection requires verified commit signatures, but commits made via git push from a workflow are never signed.

Re-create each new commit through the Git Data API instead: GitHub automatically signs commits created this way, so the resulting chain shows as "Verified" without needing to manage a GPG/SSH key for the bot.

Verified on testing repo: henry118/playground#4

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

@henry118
henry118 requested a review from cdesiniotis August 19, 2026 17:48
@henry118 henry118 self-assigned this Aug 19, 2026
@tariq1890

Copy link
Copy Markdown
Contributor

Thanks @henry118 for making this change.

This could also be applied to other repos that use the cherry-pick bot

Comment thread .github/scripts/backport.js Outdated
Comment thread .github/scripts/backport.js Outdated
@henry118
henry118 force-pushed the fix-cherrypick-bot branch from e323800 to 0129cb8 Compare August 19, 2026 19:07
Branch protection requires verified commit signatures, but commits made
via `git push` from a workflow are never signed. Re-create each new
commit through the Git Data API instead: GitHub automatically signs
commits created this way, so the resulting chain shows as "Verified"
without needing to manage a GPG/SSH key for the bot.

Signed-off-by: Henry Wang <henrwang@nvidia.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@henry118
henry118 force-pushed the fix-cherrypick-bot branch from 0129cb8 to 55cbc79 Compare August 19, 2026 19:08
@coveralls

coveralls commented Aug 19, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32291394166

Coverage remained the same at 43.959%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15262
Covered Lines: 6709
Line Coverage: 43.96%
Coverage Strength: 0.49 hits per line

💛 - Coveralls

@henry118
henry118 merged commit 357b970 into NVIDIA:main Aug 19, 2026
21 checks passed
@henry118
henry118 deleted the fix-cherrypick-bot branch August 19, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants