use Masterminds/semver instead of x/mod - #2015
Merged
Merged
Conversation
Coverage Report for CI Build 32531945592Coverage decreased (-0.03%) to 44.032%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
tariq1890
force-pushed
the
use-masterminds-semver
branch
from
August 21, 2026 00:09
31d614f to
ffa70e8
Compare
tariq1890
marked this pull request as ready for review
August 21, 2026 00:09
tariq1890
force-pushed
the
use-masterminds-semver
branch
5 times, most recently
from
August 21, 2026 01:09
aa17f62 to
4032edf
Compare
henry118
reviewed
Aug 21, 2026
tariq1890
force-pushed
the
use-masterminds-semver
branch
2 times, most recently
from
August 21, 2026 22:11
d81decc to
8573718
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
use-masterminds-semver
branch
from
August 21, 2026 22:11
8573718 to
36e8473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
golang.org/x/modwith thegithub.com/Masterminds/semver/v3module for all semver processing in the repo.Masterminds/semveris a more lightweight dependency and it also supports the parsing of semantic version strings with/without the"v"prefix. This removes the need for any explicit prefixing of version strings just so that they are usable inx/mod's semver methods.