Skip to content

Update golang toolchain #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henry118 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update golang toolchain #2018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1f8e3a
Update minimum go toolchain to 1.26
henry118 Aug 21, 2026
234c295
Fix linting issues after golang update
henry118 Aug 21, 2026
7c30ede
Bump CI golang version to 1.27
henry118 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/nvidia-cdi-hook/cudacompat/cudacompat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func (m command) getContainerForwardCompatDir(containerRoot *root, o *options) (

libs, err := containerRoot.globFiles(filepath.Join(o.cudaCompatContainerRoot, "libcuda.so.*.*"))
if err != nil {
m.logger.Warningf("Failed to find CUDA compat library: %w", err)
m.logger.Warningf("Failed to find CUDA compat library: %v", err)
return "", nil
}

Expand Down Expand Up @@ -216,7 +216,7 @@ func (m command) useCompatLibraries(libcudaCompatFile *os.File, hostDriverVersio
// libraries in the container should be used over the host driver libraries.
cudaCompatHeader, err := GetCUDACompatElfHeaderFromReader(libcudaCompatFile)
if err != nil {
m.logger.Warningf("failed to get ELF header from CUDA compat library: %w", err)
m.logger.Warningf("failed to get ELF header from CUDA compat library: %v", err)
}
if cudaCompatHeader != nil {
return cudaCompatHeader.UseCompat(compatDriverSemver, hostDriverSemver, hostCUDASemver), nil
Expand Down
2 changes: 1 addition & 1 deletion deployments/devel/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

# This Dockerfile is also used to define the golang version used in this project
# This allows dependabot to manage this version in addition to other images.
FROM golang:1.26.5
FROM golang:1.27.0

WORKDIR /work
COPY * .
Expand Down
2 changes: 1 addition & 1 deletion deployments/devel/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/NVIDIA/k8s-device-plugin/deployments/devel

go 1.25
go 1.26

require (
github.com/google/go-licenses/v2 v2.0.1
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/NVIDIA/nvidia-container-toolkit

go 1.25.0
go 1.26.0
Comment thread
tariq1890 marked this conversation as resolved.

require (
github.com/Masterminds/semver/v3 v3.5.0
Expand Down
2 changes: 1 addition & 1 deletion pkg/nvcdi/driver-wsl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (l *wsllib) newWSLDriverDiscoverer() (discover.Discover, error) {
}
defer func() {
if err := dxcore.Shutdown(); err != nil {
l.logger.Warningf("failed to shutdown dxcore: %w", err)
l.logger.Warningf("failed to shutdown dxcore: %v", err)
}
}()

Expand Down
2 changes: 1 addition & 1 deletion tests/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/NVIDIA/nvidia-container-toolkit/tests

go 1.25.0
go 1.26.0

require (
github.com/onsi/ginkgo/v2 v2.28.1
Expand Down
Loading