Skip to content

fix(worker): tear down a worker runtime whose Java bootstrap failed #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrian-niculescu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(worker): tear down a worker runtime whose Java bootstrap failed #2069

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2421b74
fix(worker): tear down a worker runtime whose Java bootstrap failed
adrian-niculescu Oct 6, 2026
84d8a99
fix(worker): detach a recovered worker runtime from Java by its own id
adrian-niculescu Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test-app/runtime/src/main/cpp/WorkerWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,18 @@ void WorkerWrapper::BackgroundLooper(std::shared_ptr<WorkerWrapper> self) {

isTerminating_ = true;

// A bootstrap that failed in Java after the native runtime was built (an
// exception from internal/ts_helpers.js, or from the logger once the
// runtime is up) never handed it back: initWorkerRuntime threw before
// returning its id. It is still this thread's current runtime, so it is
// torn down below like any other, and detached from Java by its own id.
if (runtime_ == nullptr) {
runtime_ = Runtime::GetCurrentRuntime();
if (runtime_ != nullptr) {
runtimeId = runtime_->GetId();
}
}

// Terminate any workers this worker created (nested workers). Their
// Worker object persistents live in this isolate, so they must be
// released before the isolate is disposed below. Each child cascades to
Expand Down
Loading