Skip to content

CSTACKEX-209: updating allowed snapshot name size to 255 as per the c… #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajiv-jain-netapp merged 1 commit into from
Jun 30, 2026
Merged

CSTACKEX-209: updating allowed snapshot name size to 255 as per the c… #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public class OntapStorageConstants {
public static final String PRIMARY_POOL_ID = "primary_pool_id";
public static final String ONTAP_SNAP_SIZE = "ontap_snap_size";
public static final String FILE_PATH = "file_path";
public static final int MAX_SNAPSHOT_NAME_LENGTH = 64;
public static final int MAX_SNAPSHOT_NAME_LENGTH = 255;
Comment thread
suryag1201 marked this conversation as resolved.

/** vm_snapshot_details key for ONTAP FlexVolume-level VM snapshots. */
public static final String ONTAP_FLEXVOL_SNAPSHOT = "ontapFlexVolSnapshot";
Expand Down
2 changes: 1 addition & 1 deletion ...ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ Map<String, FlexVolGroupInfo> groupVolumesByFlexVol(List<VolumeObjectTO> volumeT
*/
String buildSnapshotName(VMSnapshot vmSnapshot) {
String name = "vmsnap_" + vmSnapshot.getId() + "_" + System.currentTimeMillis();
// ONTAP snapshot names: max 256 chars, must start with letter, only alphanumeric and underscores
// ONTAP snapshot names: max 255 chars, must start with letter, only alphanumeric and underscores
Comment thread
suryag1201 marked this conversation as resolved.

@piyush5netapp piyush5netapp Jun 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment should be for cloudstack not ontap.

if (name.length() > OntapStorageConstants.MAX_SNAPSHOT_NAME_LENGTH) {
name = name.substring(0, OntapStorageConstants.MAX_SNAPSHOT_NAME_LENGTH);
}
Expand Down
Loading